Fix/log4js#5766
Conversation
|
Because async await on top level is not supported. I would suggest supporting node 16>. Seems like the tests are also failing on the develop branch. So it might seems fine 😄 . |
|
I'll rebase once again when the node branch is merged into develop. |
we're now 16+ |
I'd remake your lock file. |
|
This should be split up.
Also we need to talk about how this actually impacts Etherpad. Afaik this will break logging configs. |
|
@JohnMcLear I seem to have hit the same problem again. All pipelines fail and I didn't succeed in just cloning the project again. |
|
Dependency review is probably not happy because I had some time the latest npm in it which doesn't work out of the box. If that pull request will crash instances I would postpone this pull request to milestone 2.0 @JohnMcLear |
|
Split it down to minor changes IE axios and see what works/doesn't then go from there : ) |
|
Axios has been merged in #5776 . This contains only the log4js changes necessary to migrate to v6 |
SamTV12345
force-pushed
the
fix/log4js
branch
from
a44f2b1 to
0c3e3a8
Compare
* Updated log4js * Updated log4js version. * Removed requests and moved to axios. * Fixed startup. * Fixed windows dependency install. * Fixed import export rate limiter. * Fixed all log levels.
2 participants
This pull request updates log4js to the latest version. During testing I found out that if I bump typescript to 5.1.3 and npm enters legacy-peer-deps mode it somehow gets rid of all the old dependencies like request which I removed in this pull request too.
I don't know why there are some tests that fail I'll look into that later.