add eth_getBlockReceipts

[jsvisa]

implement #393

[lightclient]

@jsvisa this looks pretty good to me, is there a reason to not mark read for review now?

[lightclient]

(noticed small error in result formatting, should pass ci now)

[jsvisa]

@lightclient I have to add the tests in this PR as well(need a PR in rpctestgen first)

[lightclient]

My recommendation would be to undraft this with the spec so we can have client teams start approving the spec itself and in parallel work on adding the tests. But ultimately up to you.

[jsvisa]

thanks, let's move forward.

[ryanschneider]

Is the intent that this RPC can target non-canonical blocks? eth_getTransactionReceipt only returns txs included in canonical blocks (at least in geth) which is sometimes a problem. IMO it'd be nice if this RPC can target non-canonical blocks (e.g. a block that recently reorg'd out) but I'm not sure if concepts like that are included in the OpenRPC spec or not.

[jsvisa]

if this RPC can target non-canonical blocks

I think you can query this RPC(eth_getBlockReceipts) via block hash(the default behavior is requireCanonical: false)

[siladu]

Looks good. Happy to implement in Besu once this is merged.

[lightclient]

Approved in ACD 166. Just need to get the tests in now.

[jsvisa]

@lightclient sorry for the late reply, now integrated the tests, which are picked from rpctestgen