Open
Conversation
9557247 to
1aa5170
Compare
1aa5170 to
ec0405f
Compare
ec0405f to
7578428
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four commits present are each fairly atomic.
1a0daa3 moves rpctestgen into tools/cmd/rpctestgen and updates CI accordingly
0c09476 runs gofmt to fix a lint error
ced5a4d introduces a new tool in tools/cmd/specgen that generates the refs-openrpc.json file
7578428 updates the build script + ci to use the new tool, and deletes the superceded spec build logic from build.js
I used jd to ensure there's no functional diff between openrpc.json as generated by
mainand the new form:Somewhat annoyingly, the new files are in a completely different order, since it isn't feasible to roundtrip raw json in go in a way that retains the order. If we need deterministic output, we can sort the output in build.js