feat(pytest): use node id as fixture name#342
Merged
danceratopz merged 4 commits intoethereum:mainfrom Nov 7, 2023
Merged
Conversation
spencer-tb
approved these changes
Nov 6, 2023
Collaborator
spencer-tb
left a comment
There was a problem hiding this comment.
LGTM - I like it a lot!
Maybe we could rename test_filler.py to:
pytest_filler.pyplugin_filler.py
Then for src/ethereum_test_tools/tests/test_filler.py, we could rename this to framework_filler.py.
Then again test_test_filler.py makes me smile :)
Co-authored-by: spencer <spencer.taylor-brown@ethereum.org>
Member
Author
Hehe, as mentioned offline, one possibility is renaming |
danceratopz
added a commit
to danceratopz/execution-spec-tests
that referenced
this pull request
Nov 17, 2023
…ate-pytest-command To get changes from feat(pytest): use node id as fixture name ethereum#342.
danceratopz
added a commit
to danceratopz/execution-spec-tests
that referenced
this pull request
Nov 29, 2023
…ate-pytest-command This adds: ethereum#341, ethereum#342, ethereum#347.
danceratopz
added a commit
to danceratopz/execution-spec-tests
that referenced
this pull request
Feb 8, 2024
The evm blocktest command --run flag takes a regex specifying the fixtures in the json file to execute. Required as ethereum#342 changed fixture names in json to match the test ID that generated the fixture (and these always contain '[', ']', and potentially other regex syntax.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This PR:
🔗 Related Issues
Fixes #329.
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.