chore(packages/tests): update bal mappers#1661
chore(packages/tests): update bal mappers#1661spencer-tb merged 2 commits intoethereum:forks/osakafrom
Conversation
…tests (ethereum#1661) * fix(plugins/ported_from): Fix and add `--ported-from-output-file` parameter * fix(github/coverage): Use `--ported-from-output-file` * changelog
…tests (ethereum#1661) * fix(plugins/ported_from): Fix and add `--ported-from-output-file` parameter * fix(github/coverage): Use `--ported-from-output-file` * changelog
5224778 to
05840dc
Compare
There was a problem hiding this comment.
@spencer-tb this lgtm if we want to simplify things for now 👍🏼. I rebased and cleaned up the linting errors. I was going to add the mapping in this PR as well so that we can get tests passing on hive in one PR. Didn't get time today but I will work on this tomorrow. If you feel like this is not needed in the same PR, don't let this be a blocker, I'm approving 👍🏼. I think it would be nice to go through the hive flow and add the mapping here though.
Also, I suppose this makes sense in forks/osaka... but this is messy having to recreate, rebase, etc, for forks/amsterdam with every change. Thought for another scope but we should figure out how to improve the devex here 😅.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/osaka #1661 +/- ##
============================================
Coverage 86.07% 86.07%
============================================
Files 743 743
Lines 44078 44078
Branches 3894 3894
============================================
Hits 37938 37938
Misses 5659 5659
Partials 481 481
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for fixing! Will merge and can follow up in another PR.
Do you mean the ruleset here: https://github.com/ethereum/execution-specs/blob/forks/osaka/packages/testing/src/execution_testing/cli/pytest_commands/plugins/consume/simulators/helpers/ruleset.py#L483-L504
I commented a small potential improvement here for the STEEL call: ethsteel/pm#4 (comment) |
🗒️ Description
Note: must be rebased once #1654 is merged.
This PR should make all ELs (BAL enabled) pass all the consume engine tests. I'm not sure we need to be super strict on the exception checking for BAL. I think we should only have a single BAL exception based on what the clients are returning. More granularity would be nice for debugging, but if clients are failing for the BAL hash mismatch at the highest level (i.e not stating why) I feel this is enough. This PR is also to prompt discussion.
🔗 Related Issues or PRs
N/A.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e statictype(scope):.Cute Animal Picture