feat: add SLOAD/SSTORE mixed benchmarks from execution-spec-tests#1697
Merged
danceratopz merged 2 commits intoethereum:forks/osakafrom Oct 30, 2025
Merged
Conversation
Migrate benchmarks from ethereum/execution-spec-tests PR #2256 - Added test_mixed_sload_sstore with configurable ratios: 50-50, 70-30, 90-10 SLOAD/SSTORE splits - Added test_sload_empty_erc20_balanceof for SLOAD-only benchmark - Added test_sstore_erc20_approve for SSTORE-only benchmark - Tests use ERC20 function selectors (balanceOf, approve) - Support for pre-deployed contracts via address_stubs - Parameterized tests with num_contracts: 1, 5, 10, 20, 100 Follows package naming conventions from PR ethereum#1654
CPerezz
force-pushed
the
feat/sstore-sload-mixed-benchmarks
branch
from
7ef448c to
c338969
Compare
- Add AddressStubs import from execute.pre_alloc - Add type annotations for address_stubs parameter - Add None checks before accessing address_stubs.root - Fixes mypy errors for all benchmark test functions
LouisTsai-Csie
approved these changes
Oct 29, 2025
danceratopz
approved these changes
Oct 30, 2025
Member
danceratopz
left a comment
danceratopz
left a comment
There was a problem hiding this comment.
LGTM! The README.md should get picked up by the doc flow and included in the test case reference (the old, no longer updated, version here). We can revisit and fix this once it's been re-enabled (cf #1659).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated benchmark tests from ethereum/execution-spec-tests#2256:
These benchmarks stress test client implementations with state-heavy operations across multiple contracts to identify performance bottlenecks.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture