Skip to content

fix(tests): EIP-7883 minor fixes#2082

Merged
fselmo merged 3 commits intoethereum:forks/amsterdamfrom
monad-developers:fix/eip7883
Feb 10, 2026
Merged

fix(tests): EIP-7883 minor fixes#2082
fselmo merged 3 commits intoethereum:forks/amsterdamfrom
monad-developers:fix/eip7883

Conversation

@pdobacz
Copy link
Contributor

@pdobacz pdobacz commented Jan 27, 2026

🗒️ Description

Two unrelated fixes to the EIP-7883 testing:

  • fixing the gas formula - I'm not sure why the (len(modexp_expected) // 32) factor was there, as the number of SSTOREs never depended on the length. At the same time there were several SSTOREs done throughout the test. Also the precompile gas part of the tx gas must take into account that the 63/64th rule is going to apply
  • new gas should apply for forks coming after Osaka, so that forks that might not define its relation to Osaka use old gas

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.07%. Comparing base (720caf4) to head (7287589).
⚠️ Report is 2 commits behind head on forks/amsterdam.

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #2082   +/-   ##
================================================
  Coverage            86.07%   86.07%           
================================================
  Files                  599      599           
  Lines                39472    39472           
  Branches              3780     3780           
================================================
  Hits                 33977    33977           
  Misses                4862     4862           
  Partials               633      633           
Flag Coverage Δ
unittests 86.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm, really nice find 👍🏼. Just one clarifying question for a bit more accuracy here before approving.

@pdobacz pdobacz requested a review from fselmo February 10, 2026 15:44
Copy link
Contributor

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fselmo fselmo merged commit feaad6c into ethereum:forks/amsterdam Feb 10, 2026
12 checks passed
@pdobacz pdobacz deleted the fix/eip7883 branch February 10, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants