Fixes transaction parameters for different transaction types.#293
Fixes transaction parameters for different transaction types.#293MicahZoltu wants to merge 1 commit intoethereum:masterfrom
Conversation
Note: The `type` should be a single value literal for each transaction type, but I don't know how to do that. I moved the type into the specific transactions in hopes that someone will be able to fix it to be the appropriate literal instead of a byte for each.
Codecov Report
@@ Coverage Diff @@
## master #293 +/- ##
=======================================
Coverage 93.55% 93.55%
=======================================
Files 28 28
Lines 1676 1676
=======================================
Hits 1568 1568
Misses 108 108
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
@MicahZoltu who should I ping to review this as a sanity check ? |
|
@lightclient or @alita-moore would probably be a good candidate. |
|
@MicahZoltu 1) I think this should be moved to the |
|
I opened an issue on that repo to track this: ethereum/execution-apis#41 |
|
Ah, I didn't realize that we moved JSON-RPC spec. |
…eum#293) * style: fix spelling for cspell * framework: add a code class to generate switch-case expressions * tests: refactor tstorage reentrancy test to use switch * framework: replace STOP with a JUMP to end of switch-case construct This allows using Switch nested within other bytecode. * framework: add tests for switch with large jump lengths * refactor: give JUMP length variable a more consistent name * style: add comment explaining bytecode construction * style: fix typo in docstring * refactor: simplify action_jump_length calculation in loop * style: fix/improve explanation in comment * framework: rename BytecodeCase; add CalldataCase (#25) * tools: Rename BytecodeCase, add case_calldata * tests/cancun: update switch tests * style: use black formatting * refactor: rewrite case_calldata() as a dataclass CalldataCase * tests: refactor tstorage reentrancy test to use CalldataCase --------- Co-authored-by: danceratopz <danceratopz@gmail.com> --------- Co-authored-by: Mario Vega <marioevz@gmail.com>
5 participants
Note: The
typeshould be a single value literal for each transaction type, but I don't know how to do that. I moved the type into the specific transactions in hopes that someone will be able to fix it to be the appropriate literal instead of a byte for each.