chore: replace inline link-checker scripts with ethersphere submodule#790
Open
NoahMaizels wants to merge 3 commits intomasterfrom
Open
chore: replace inline link-checker scripts with ethersphere submodule#790NoahMaizels wants to merge 3 commits intomasterfrom
NoahMaizels wants to merge 3 commits intomasterfrom
Conversation
Moves the two link-checker Python scripts out of scripts/ and into the canonical ethersphere/docusaurus-link-checker submodule at tools/docusaurus-link-checker. Updates check:links npm script to point at the submodule, adds a build:check convenience script, and documents usage (flags, submodule init) in README. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
✅ Deploy Preview for test-twitter-preview-testing-3 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Using `npm run check:links` in the chain doesn't forward extra args correctly — npm's `--` passthrough only appends to the outermost command, so flags would land on `npm run` not on the python script. Call python directly so `npm run build:check -- --mode live` works. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds precheck:links hook so npm run check:links always pulls the latest submodule commit before running. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/check_links.pyandscripts/check_live_links.py(2131 lines)tools/docusaurus-link-checkercheck:linksnpm script to point at the submodulebuild:checkconvenience script (build + link check in one command)Usage after this PR
Test plan
git submodule update --init→npm run check:linkslaunches the checkernpm run check:links -- --mode local --no-externalskips external URLsnpm run build:checkruns a full build then launches the checkerscripts/check_links.pyandscripts/check_live_links.pyno longer exist🤖 Generated with Claude Code