Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Added support for optional
pre-ethd-update.shandpost-ethd-update.shhook scripts that execute during ethd update and ethd config commands, allowing users to run custom automation before and after configuration/update operations.Related issue
Closes #2459
Use Cases & Justification
These hooks enable users to automate workflows around Eth Docker operations without modifying the core ethd script, while keeping standard commands and workflow. By integrating the scripts into the repo, users can guarantee the scripts are run without having to remember or worry that other node maintainers follow an update policy.
The hooks are very powerful and customizable based on each user's use case. I think they empower those looking for the ability to rollback changes or have 100% reproducibility over time. I believe this is important because ethd update makes changes you may not expect or know about to your configuration file.
ethd configwas included because even advanced users can take advantage of this command for updates like changing clients, and this can give them more confidence knowing the exact changes.Additionally, other ideas include:
Behavior