-
Notifications
You must be signed in to change notification settings - Fork 34
feat: make amount contextful on partial deposit #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make amount contextful on partial deposit #382
Conversation
|
Sorry it took so long to get to this. Simple enough PR but can we add a unit test to verify the proper usage of the multiplier? Would be nice to see one for the deposit flow as well if possible |
Hey ! A few unit tests using the multiplier were added in commit 17ba390, mostly in |
|
Added more tests for partial deposit 👍 |
|
Test Coverage: Download HTML Report |
valefar-on-discord
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you and appreciate your patience!
What I did
Related issue
For compatibility, added the existing amount calculation logic to partial deposit flow
(not mandatory) A picture of a cute animal, if possible in relation to what you did
