Skip to content

Conversation

@Wagalidoom
Copy link

What I did

Related issue
For compatibility, added the existing amount calculation logic to partial deposit flow

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@valefar-on-discord
Copy link
Collaborator

Sorry it took so long to get to this.

Simple enough PR but can we add a unit test to verify the proper usage of the multiplier? Would be nice to see one for the deposit flow as well if possible

@Wagalidoom
Copy link
Author

Wagalidoom commented Aug 5, 2025

Sorry it took so long to get to this.

Simple enough PR but can we add a unit test to verify the proper usage of the multiplier? Would be nice to see one for the deposit flow as well if possible

Hey ! A few unit tests using the multiplier were added in commit 17ba390, mostly in tests/test_cli/test_new_mnemonic.py
I will add more tests in tests/test_cli/test_partial_deposit.py as well

@Wagalidoom
Copy link
Author

Added more tests for partial deposit 👍

@valefar-on-discord valefar-on-discord added the run-tests Request tests to run on the CI label Aug 7, 2025
@github-actions
Copy link

github-actions bot commented Aug 7, 2025

Test Coverage: Download HTML Report

Name                                                                 Stmts   Miss  Cover
----------------------------------------------------------------------------------------
ethstaker_deposit/__init__.py                                            1      0   100%
ethstaker_deposit/bls_to_execution_change_keystore.py                   32      2    94%
ethstaker_deposit/cli/__init__.py                                        0      0   100%
ethstaker_deposit/cli/existing_mnemonic.py                              45      0   100%
ethstaker_deposit/cli/exit_transaction_keystore.py                      44      3    93%
ethstaker_deposit/cli/exit_transaction_mnemonic.py                      67      9    87%
ethstaker_deposit/cli/generate_bls_to_execution_change.py               62     11    82%
ethstaker_deposit/cli/generate_bls_to_execution_change_keystore.py      45      3    93%
ethstaker_deposit/cli/generate_keys.py                                  66      2    97%
ethstaker_deposit/cli/new_mnemonic.py                                   33      0   100%
ethstaker_deposit/cli/partial_deposit.py                                70      5    93%
ethstaker_deposit/cli/test_keystore.py                                  23      1    96%
ethstaker_deposit/credentials.py                                       208     78    62%
ethstaker_deposit/deposit.py                                            58     10    83%
ethstaker_deposit/exceptions.py                                          6      0   100%
ethstaker_deposit/key_handling/__init__.py                               0      0   100%
ethstaker_deposit/key_handling/key_derivation/__init__.py                0      0   100%
ethstaker_deposit/key_handling/key_derivation/mnemonic.py               95      6    94%
ethstaker_deposit/key_handling/key_derivation/path.py                   17      1    94%
ethstaker_deposit/key_handling/key_derivation/tree.py                   36      0   100%
ethstaker_deposit/key_handling/keystore.py                              98      0   100%
ethstaker_deposit/settings.py                                           35      0   100%
ethstaker_deposit/utils/__init__.py                                      0      0   100%
ethstaker_deposit/utils/ascii_art.py                                     2      0   100%
ethstaker_deposit/utils/click.py                                        98      3    97%
ethstaker_deposit/utils/config.py                                        3      0   100%
ethstaker_deposit/utils/constants.py                                    29      0   100%
ethstaker_deposit/utils/crypto.py                                       29      1    97%
ethstaker_deposit/utils/deposit.py                                       8      0   100%
ethstaker_deposit/utils/exit_transaction.py                             23      0   100%
ethstaker_deposit/utils/file_handling.py                                13      0   100%
ethstaker_deposit/utils/intl.py                                         55      3    95%
ethstaker_deposit/utils/ssz.py                                          60      7    88%
ethstaker_deposit/utils/terminal.py                                     29     21    28%
ethstaker_deposit/utils/validation.py                                  264     55    79%
----------------------------------------------------------------------------------------
TOTAL                                                                 1654    221    87%

Copy link
Collaborator

@valefar-on-discord valefar-on-discord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and appreciate your patience!

@valefar-on-discord valefar-on-discord merged commit 965d1eb into ethstaker:main Aug 7, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-tests Request tests to run on the CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants