-
Notifications
You must be signed in to change notification settings - Fork 34
New generate mnemonic command #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Everything looks good from my end. I think this checks all the boxes that was asked. Is this something we want to document or have it be a hidden command to not confuse with |
|
It would need to be documented and some unit tests would need to be added. I'm not sure what's the best way to avoid any confusion between this command and the existing new-mnemonic one. I'm thinking about a detailed description in the documentation and the stdout when you run this command could help. |
|
I've added documentation about this command to better explains this in relation with the existing |
|
Test Coverage: Download HTML Report |
valefar-on-discord
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤌 Great stuff
What I did
Implements a new
generate-mnemoniccommand to simply generate a new mnemonic to be displayed on screen or written to a file.Related issue
Related to #283, #170