Skip to content

Conversation

@yorickdowne
Copy link

@yorickdowne yorickdowne commented Oct 8, 2025

What I did

Successfully tested changes to __version__ so dependabot works. Particularly, change attr to file: uv can read the version without needing to import ethstaker_deposit, which hasn't been built in dependabot's restricted build environment

@yorickdowne yorickdowne force-pushed the fix-dependa-uv branch 2 times, most recently from 3e7c16b to bb6367d Compare October 8, 2025 13:46
@yorickdowne yorickdowne marked this pull request as draft October 8, 2025 13:46
@yorickdowne yorickdowne force-pushed the fix-dependa-uv branch 2 times, most recently from af763ca to 0a079ce Compare October 8, 2025 14:26
@yorickdowne yorickdowne changed the title Fix dependa uv Fix dependabot uv runs Oct 8, 2025
@yorickdowne yorickdowne marked this pull request as ready for review October 8, 2025 14:29
@yorickdowne yorickdowne force-pushed the fix-dependa-uv branch 2 times, most recently from 6e72524 to d914a05 Compare October 8, 2025 15:05
@remyroy
Copy link
Member

remyroy commented Oct 8, 2025

I'm getting this error message when trying to run uv run ethstaker_deposit --version on this PR:

error: Failed to generate package metadata for `ethstaker-deposit @ editable+.`
  Caused by: The build backend returned an error
  Caused by: Call to `setuptools.build_meta.build_editable` failed (exit status: 1)

[stdout]
running egg_info

[stderr]
Traceback (most recent call last):
  File "/home/remyroy/.cache/uv/builds-v0/.tmpWCMMp3/lib/python3.13/site-packages/setuptools/_normalization.py", line 61, in safe_version
    return str(packaging.version.Version(v))
               ~~~~~~~~~~~~~~~~~~~~~~~~~^^^
  File "/home/remyroy/.cache/uv/builds-v0/.tmpWCMMp3/lib/python3.13/site-packages/setuptools/_vendor/packaging/version.py", line 202, in __init__
    raise InvalidVersion(f"Invalid version: {version!r}")
packaging.version.InvalidVersion: Invalid version: "__version__.=.'1.2.2'\n"

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<string>", line 14, in <module>
    requires = get_requires_for_build({})
  File "/home/remyroy/.cache/uv/builds-v0/.tmpWCMMp3/lib/python3.13/site-packages/setuptools/build_meta.py", line 473, in get_requires_for_build_editable
    return self.get_requires_for_build_wheel(config_settings)
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
  File "/home/remyroy/.cache/uv/builds-v0/.tmpWCMMp3/lib/python3.13/site-packages/setuptools/build_meta.py", line 331, in get_requires_for_build_wheel
    return self._get_build_requires(config_settings, requirements=[])
           ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/remyroy/.cache/uv/builds-v0/.tmpWCMMp3/lib/python3.13/site-packages/setuptools/build_meta.py", line 301, in _get_build_requires
    self.run_setup()
    ~~~~~~~~~~~~~~^^
  File "/home/remyroy/.cache/uv/builds-v0/.tmpWCMMp3/lib/python3.13/site-packages/setuptools/build_meta.py", line 317, in run_setup
    exec(code, locals())
    ~~~~^^^^^^^^^^^^^^^^
  File "<string>", line 1, in <module>
    import sys
    
  File "/home/remyroy/.cache/uv/builds-v0/.tmpWCMMp3/lib/python3.13/site-packages/setuptools/__init__.py", line 115, in setup
    return distutils.core.setup(**attrs)
           ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
  File "/home/remyroy/.cache/uv/builds-v0/.tmpWCMMp3/lib/python3.13/site-packages/setuptools/_distutils/core.py", line 186, in setup
    return run_commands(dist)
  File "/home/remyroy/.cache/uv/builds-v0/.tmpWCMMp3/lib/python3.13/site-packages/setuptools/_distutils/core.py", line 202, in run_commands
    dist.run_commands()
    ~~~~~~~~~~~~~~~~~^^
  File "/home/remyroy/.cache/uv/builds-v0/.tmpWCMMp3/lib/python3.13/site-packages/setuptools/_distutils/dist.py", line 1002, in run_commands
    self.run_command(cmd)
    ~~~~~~~~~~~~~~~~^^^^^
  File "/home/remyroy/.cache/uv/builds-v0/.tmpWCMMp3/lib/python3.13/site-packages/setuptools/dist.py", line 1102, in run_command
    super().run_command(command)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^
  File "/home/remyroy/.cache/uv/builds-v0/.tmpWCMMp3/lib/python3.13/site-packages/setuptools/_distutils/dist.py", line 1020, in run_command
    cmd_obj.ensure_finalized()
    ~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/home/remyroy/.cache/uv/builds-v0/.tmpWCMMp3/lib/python3.13/site-packages/setuptools/_distutils/cmd.py", line 135, in ensure_finalized
    self.finalize_options()
    ~~~~~~~~~~~~~~~~~~~~~^^
  File "/home/remyroy/.cache/uv/builds-v0/.tmpWCMMp3/lib/python3.13/site-packages/setuptools/command/egg_info.py", line 225, in finalize_options
    self.egg_version = self.tagged_version()
                       ~~~~~~~~~~~~~~~~~~~^^
  File "/home/remyroy/.cache/uv/builds-v0/.tmpWCMMp3/lib/python3.13/site-packages/setuptools/command/egg_info.py", line 131, in tagged_version
    return _normalization.safe_version(tagged)
           ~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
  File "/home/remyroy/.cache/uv/builds-v0/.tmpWCMMp3/lib/python3.13/site-packages/setuptools/_normalization.py", line 64, in safe_version
    return str(packaging.version.Version(attempt))
               ~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
  File "/home/remyroy/.cache/uv/builds-v0/.tmpWCMMp3/lib/python3.13/site-packages/setuptools/_vendor/packaging/version.py", line 202, in __init__
    raise InvalidVersion(f"Invalid version: {version!r}")
packaging.version.InvalidVersion: Invalid version: '__version__.-.-1.2.2-'

hint: This usually indicates a problem with the package or the build environment.

@remyroy
Copy link
Member

remyroy commented Oct 8, 2025

It works now with d914a05 being included.

Copy link
Member

@remyroy remyroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should also update our release process for this new change in docs/src/release_process.md.

@yorickdowne
Copy link
Author

Good catch @remyroy . Added a change to release docs

Copy link
Member

@remyroy remyroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 18 of docs/src/release_process.md also need to be updated for this new VERSION value location.

@yorickdowne
Copy link
Author

Change made, @remyroy

Copy link
Member

@remyroy remyroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is good! I'll let you merge when you feel like this won't break your other work.

@yorickdowne yorickdowne merged commit 73dc044 into ethstaker:main Oct 8, 2025
3 checks passed
yorickdowne added a commit that referenced this pull request Oct 8, 2025
* Improve version handling for dependabot (#412)

* Bump click from 8.1.8 to 8.3.0 in the pip-deps group

Bumps the pip-deps group with 1 update: [click](https://github.com/pallets/click).

Updates `click` from 8.1.8 to 8.3.0
- [Release notes](https://github.com/pallets/click/releases)
- [Changelog](https://github.com/pallets/click/blob/main/CHANGES.rst)
- [Commits](pallets/click@8.1.8...8.3.0)

---
updated-dependencies:
- dependency-name: click
  dependency-version: 8.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: pip-deps
...

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
yorickdowne added a commit that referenced this pull request Oct 8, 2025
* Improve version handling for dependabot (#412)

* Bump click from 8.1.8 to 8.3.0 in the pip-deps group

Bumps the pip-deps group with 1 update: [click](https://github.com/pallets/click).

Updates `click` from 8.1.8 to 8.3.0
- [Release notes](https://github.com/pallets/click/releases)
- [Changelog](https://github.com/pallets/click/blob/main/CHANGES.rst)
- [Commits](pallets/click@8.1.8...8.3.0)

---
updated-dependencies:
- dependency-name: click
  dependency-version: 8.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: pip-deps
...

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
yorickdowne added a commit that referenced this pull request Oct 8, 2025
* Improve version handling for dependabot (#412)

* Bump click from 8.1.8 to 8.3.0 in the pip-deps group

Bumps the pip-deps group with 1 update: [click](https://github.com/pallets/click).

Updates `click` from 8.1.8 to 8.3.0
- [Release notes](https://github.com/pallets/click/releases)
- [Changelog](https://github.com/pallets/click/blob/main/CHANGES.rst)
- [Commits](pallets/click@8.1.8...8.3.0)

---
updated-dependencies:
- dependency-name: click
  dependency-version: 8.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: pip-deps
...

Signed-off-by: dependabot[bot] <support@github.com>

* More test fixes

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
remyroy pushed a commit that referenced this pull request Oct 8, 2025
* Bump click from 8.1.8 to 8.3.0 in the pip-deps group

Bumps the pip-deps group with 1 update: [click](https://github.com/pallets/click).


Updates `click` from 8.1.8 to 8.3.0
- [Release notes](https://github.com/pallets/click/releases)
- [Changelog](https://github.com/pallets/click/blob/main/CHANGES.rst)
- [Commits](pallets/click@8.1.8...8.3.0)

---
updated-dependencies:
- dependency-name: click
  dependency-version: 8.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: pip-deps
...

Signed-off-by: dependabot[bot] <support@github.com>

* Remove mypy ignore for click.progressbar (#414)

* Allow tests to work with click 8.3.0 (#416)

* Click 8.3.0 (#417)

* Improve version handling for dependabot (#412)

* Bump click from 8.1.8 to 8.3.0 in the pip-deps group

Bumps the pip-deps group with 1 update: [click](https://github.com/pallets/click).

Updates `click` from 8.1.8 to 8.3.0
- [Release notes](https://github.com/pallets/click/releases)
- [Changelog](https://github.com/pallets/click/blob/main/CHANGES.rst)
- [Commits](pallets/click@8.1.8...8.3.0)

---
updated-dependencies:
- dependency-name: click
  dependency-version: 8.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: pip-deps
...

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Click 8.3.0 (#418)

* Improve version handling for dependabot (#412)

* Bump click from 8.1.8 to 8.3.0 in the pip-deps group

Bumps the pip-deps group with 1 update: [click](https://github.com/pallets/click).

Updates `click` from 8.1.8 to 8.3.0
- [Release notes](https://github.com/pallets/click/releases)
- [Changelog](https://github.com/pallets/click/blob/main/CHANGES.rst)
- [Commits](pallets/click@8.1.8...8.3.0)

---
updated-dependencies:
- dependency-name: click
  dependency-version: 8.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: pip-deps
...

Signed-off-by: dependabot[bot] <support@github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Click 8.3.0 (#419)

* Improve version handling for dependabot (#412)

* Bump click from 8.1.8 to 8.3.0 in the pip-deps group

Bumps the pip-deps group with 1 update: [click](https://github.com/pallets/click).

Updates `click` from 8.1.8 to 8.3.0
- [Release notes](https://github.com/pallets/click/releases)
- [Changelog](https://github.com/pallets/click/blob/main/CHANGES.rst)
- [Commits](pallets/click@8.1.8...8.3.0)

---
updated-dependencies:
- dependency-name: click
  dependency-version: 8.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: pip-deps
...

Signed-off-by: dependabot[bot] <support@github.com>

* More test fixes

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: yorickdowne <71337066+yorickdowne@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants