Skip to content

Conversation

@blockchaindevsh
Copy link
Collaborator

@blockchaindevsh blockchaindevsh commented Mar 16, 2024

add L1Block.blockHash to fetch 8191 history L1 blockhash not including the current one.

TODO:

  1. add e2e test

Copy link

@qizhou qizhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we separate the two features (SoulETH and RANDAO) into two PRs?

@blockchaindevsh
Copy link
Collaborator Author

blockchaindevsh commented Mar 16, 2024

Can we separate the two features (SoulETH and RANDAO) into two PRs?

SoulETH related changes are moved here.

ES part is moved here

@blockchaindevsh blockchaindevsh changed the title changes of optimism side changes for randao Mar 21, 2024
} else {
lower = upper - HISTORY_SIZE + 1;
}
if (_historyNumber >= lower && _historyNumber < upper) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_historyNumber <= upper ?

@blockchaindevsh blockchaindevsh merged commit 08f515c into ethstorage:op-es Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants