modify Nary, adapted to version 1.2.0 #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+1037
to
+1047
| function _traceAncestorV2(Position _position, uint256 _intervalDepth) | ||
| internal | ||
| pure | ||
| returns (Position ancestor_) | ||
| { | ||
| if (_position.depth() % _intervalDepth != 0) { | ||
| revert InvalidPosition(); | ||
| } | ||
| ancestor_ = _position.traceAncestor(); | ||
| return _firstValidRightIndex(ancestor_, _intervalDepth); | ||
| } |
Check failure
Code scanning / Slither
Weak PRNG
Comment on lines
+1053
to
+1062
| function _firstValidRightIndex(Position _position, uint256 _intervalDepth) | ||
| internal | ||
| pure | ||
| returns (Position first_) | ||
| { | ||
| first_ = _position; | ||
| for (uint64 start = first_.depth(); start % _intervalDepth != 0; start++) { | ||
| first_ = first_.right(); | ||
| } | ||
| } |
Check failure
Code scanning / Slither
Weak PRNG
qizhou
approved these changes
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forge test --mc FaultDisputeGame3_Test
forge test --mc FaultDispute3_1v1_Actors_Test