Skip to content

fix ancestor search bugs and support DA in stepV2() #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
qizhou merged 2 commits into from
Jul 18, 2024
Merged

fix ancestor search bugs and support DA in stepV2() #36

qizhou merged 2 commits into from
Jul 18, 2024

Conversation

@qizhou
Copy link

@qizhou qizhou commented Jul 16, 2024

  • Fix some bugs of searching ancestor in mutli-section case
  • Use LibDA (calldata) to retrieve the actual claim hash
  • Pass forge test --mc FaultDisputeGameN_Test --mt 'test_stepAttackDummyClaim_attackBranch.*', which fails previous code.

@qizhou qizhou requested review from JustXxx and dajuguan July 16, 2024 16:19
dajuguan
dajuguan approved these changes Jul 18, 2024
View reviewed changes
Copy link

@dajuguan dajuguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all test passed

@qizhou qizhou merged commit 7d8dd8d into develop Jul 18, 2024
@qizhou qizhou deleted the develop-stepv2 branch July 18, 2024 14:17
This was referenced Jul 20, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dajuguan dajuguan dajuguan approved these changes

@JustXxx JustXxx Awaiting requested review from JustXxx

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qizhou @dajuguan