fix batcher bug #96
Merged
fix batcher bug #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How did you test? |
Collaborator
Author
|
I haven't tested yet, op-batcher has run out of gas now. DL also met this problem, the fix worked for him. This bug is introduced in this PR. |
qzhodl
approved these changes
Dec 1, 2024
qizhou
reviewed
Dec 4, 2024
qizhou
left a comment
qizhou
left a comment
There was a problem hiding this comment.
The description should be updated as a simple cache mechanism is introduced to check if an address is a contract or not.
op-batcher/batcher/driver.go
Outdated
| } | ||
|
|
||
| } | ||
| // Don't set GasLimit when inbox is contract so that later on `EstimateGas` will be called |
There was a problem hiding this comment.
I feel the comments here should be updated to
Suggested change
| // Don't set GasLimit when inbox is contract so that later on `EstimateGas` will be called | |
| // Set GasLimit as intrinstic gas if the inbox is EOA, otherwise | |
| // Leave GasLimit unset when inbox is contract so that later on `EstimateGas` will be called |
qizhou
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's causing all batcher transactions to fail.
Upstream also has a tiny bug here when estimating blob tx gas limit when increasing gas price, but this bug here is the primary reason all batcher txes failed for the new devnet.