Parallelize CI Jobs#263
Merged
Merged
Conversation
PSalant726
force-pushed
the
ps/parallelize-ci
branch
7 times, most recently
from
28004b8 to
0f2b8d9
Compare
PSalant726
force-pushed
the
ps/parallelize-ci
branch
from
0f2b8d9 to
5ca0d1d
Compare
PSalant726
force-pushed
the
ps/parallelize-ci
branch
2 times, most recently
from
54cebad to
64bcfcc
Compare
PSalant726
force-pushed
the
ps/parallelize-ci
branch
from
64bcfcc to
39b13eb
Compare
PSalant726
commented
Dec 2, 2021
PSalant726
added
dev experience
added 8 commits
December 6, 2021 14:55
…n the makefile to use specific images, update the image names in the pr_checks file
…ks as expected, checkout the repo in each CI step since the makefile is in use again
Contributor
|
im very confused at this point...it is loading the cache from the image but not using it for some reason? https://github.com/ethyca/fides/runs/4438492231?check_suite_focus=true#step:5:62 |
added 5 commits
December 6, 2021 17:46
ThomasLaPiana
approved these changes
Dec 8, 2021
Contributor
ThomasLaPiana
left a comment
ThomasLaPiana
left a comment
There was a problem hiding this comment.
Had to make some changes but got it working
Contributor
|
@PSalant726 can you give this a quick review? i finally got it! but want to make sure what I did isn't too crazy |
Contributor
|
i merged main and tested the new pre-commit checks, they work as well |
PSalant726
commented
Dec 10, 2021
Contributor
Author
PSalant726
left a comment
PSalant726
left a comment
There was a problem hiding this comment.
@ThomasLaPiana Nice Docker-fu! Just some minor things. Only the first comment is a blocker, but I can't "request changes" since I'm the original author.
ThomasLaPiana
pushed a commit
that referenced
this pull request
Aug 17, 2022
ThomasLaPiana
pushed a commit
that referenced
this pull request
Sep 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #228
Code Changes
Steps to Confirm
Pre-Merge Checklist
Description Of Changes
Attempts to create and store a fidesctl Docker image artifact that is then shared between CI jobs within a single workflow.