System form rework#3920
Merged
Merged
Conversation
…m and PrivacyDeclaration.
…nt_controller in the future. Add source/destination with the intent to deprecate system egress and ingress. - Bump fideslang temporary commit and add starting draft of data migration.
…to corresponding system fields where applicable/
…eclaration dataset references to system dataset references. - Cleanup how joint_controller_info and third_parties are created by putting semicolons in between combined elements
…elds to systems.yml.
- Add system create/update tests around new expected fields - Add tests around data stewards now being returned in system response.
- Bump fideslang branch commit - Revert systems yaml changes, it seems like this file actually annotates fides service itself - Python cleanup in system dictionary data migration - Changing pending deprecation/will be deprecated code comments to deprecated
10 tasks
Passing run #3622 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
||||||||||||||||||||
Contributor
TheAndrewJackson
left a comment
TheAndrewJackson
left a comment
There was a problem hiding this comment.
I've finished initial pass of the code. It's looking good! Now I'm going to go through and test everything
Contributor
|
It looks like some of the fields aren't saving and might need the keys to be updated. Some that I'm seeing are:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3827
Description Of Changes
Update system information and data use tabs in system view with new form designs and new field specifications
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md