Skip to content

Conversation

@gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Oct 22, 2025

Ticket ENG-1638

Description Of Changes

Replaced the raw URN text display with a visual breadcrumb navigation component that shows the database hierarchy (database → schema → table) with appropriate icons for each resource type. The breadcrumb makes it easier to understand the data structure at a glance.

Temporarily disabled the ClassifierProgress component rendering (returns null) while awaiting proper confidence score implementation from the backend. The full component implementation exists as FutureClassifierProgress for when backend support is ready.

Fixes the size of the Sparkle icons on buttons in Schema explorer

Code Changes

  • Added parseResourceBreadcrumbs utility function to parse URN strings into breadcrumb items with hierarchical icons
  • Replaced URN text display with AntBreadcrumb component in MonitorFieldListItem
  • Extracted icon mapping to MAP_DATASTORE_RESOURCE_TYPE_TO_ICON constant for reuse across tree and list views
  • Refactored MonitorTree to use the shared icon mapping constant instead of inline switch statement
  • Created ClassifierProgress placeholder component that returns null until backend confidence scores are available
  • Added comprehensive test suite for URN parsing with edge cases and malformed input handling
  • Created dedicated SCSS module for monitor field list item styling
  • Extracted renderBreadcrumbItem helper function for breadcrumb rendering logic

Steps to Confirm

  1. Navigate to the data discovery action center fields view
  2. Verify breadcrumbs display with database/schema/table/nested-field icons instead of raw URN text
  3. Verify the last breadcrumb item (parent field/table) appears the same as the rest (breadcrumb highlights that last item typically)
  4. Verify the Confidence level component doesn't render anywhere, including the Drawer
  5. Verify the hover state of the list item's button component (field name)

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link

vercel bot commented Oct 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ready Ready Preview Comment Oct 22, 2025 10:44pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
fides-privacy-center Ignored Ignored Oct 22, 2025 10:44pm

@gilluminate gilluminate force-pushed the gill/ENG-1638/parse-location-urns branch from f357f3b to 3215e9e Compare October 22, 2025 22:39
@gilluminate gilluminate marked this pull request as ready for review October 22, 2025 22:46
@gilluminate gilluminate requested a review from a team as a code owner October 22, 2025 22:46
@gilluminate gilluminate requested review from vcruces and removed request for a team and vcruces October 22, 2025 22:46
greptile-apps[bot]

This comment was marked as outdated.

@gilluminate gilluminate enabled auto-merge October 22, 2025 23:11
Copy link
Contributor

@jack-gale-ethyca jack-gale-ethyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great

@gilluminate gilluminate added this pull request to the merge queue Oct 23, 2025
Merged via the queue into main with commit e7a4e46 Oct 23, 2025
45 of 46 checks passed
@gilluminate gilluminate deleted the gill/ENG-1638/parse-location-urns branch October 23, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants