Skip to content

Conversation

@eastandwestwind
Copy link
Contributor

@eastandwestwind eastandwestwind commented Oct 23, 2025

Ticket ENG-1086

❗ Please test alongside the Fidesplus PR https://github.com/ethyca/fidesplus/pull/2677

Description Of Changes

Updates legacy taxonomy consts for custom taxonomy API work.

Our legacy taxonomies are auto-inserted into the DB on server start. these include:

# Seed legacy taxonomies that are managed by the system
    op.execute(
        """
        INSERT INTO taxonomy (id, created_at, updated_at, fides_key, organization_fides_key, tags, name, description)
        VALUES
          ('data_category', now(), now(), 'data_category', NULL, NULL, 'Data categories', 'Taxonomy for data categories'),
          ('data_use', now(), now(), 'data_use', NULL, NULL, 'Data uses', 'Taxonomy for data uses'),
          ('data_subject', now(), now(), 'data_subject', NULL, NULL, 'Data subjects', 'Taxonomy for data subjects'),
          ('system_group', now(), now(), 'system_group', NULL, NULL, 'System groups', 'Taxonomy for system groups')
        """
    )

We have to ensure any time we need to check / access legacy taxonomies, we use the fides_key instead of the resource type. I've also updated the const to include system_group.

Code Changes

  • Updated consts to use fides_key instead of resource type for taxonomies
  • Updated const to include "system_groups"

Steps to Confirm

  1. Confirm tests pass
  2. Test alongside fidesplus PR (https://github.com/ethyca/fidesplus/pull/2677)
  3. Using Swagger (http://localhost:8080/docs#/Plus), hit the following endpoints and confirm you are able to perform all operations:
Taxonomy-level operations:

GET /taxonomies - List all custom taxonomies

POST /taxonomies - Create a new custom taxonomy

PUT /taxonomies/{taxonomy_type} - Update a taxonomy

DELETE /taxonomies/{taxonomy_type} - Delete a taxonomy

Taxonomy Element operations:

GET /taxonomies/{taxonomy_type}/elements - List elements for a taxonomy

POST /taxonomies/{taxonomy_type}/elements - Create a new element

PUT /taxonomies/{taxonomy_type}/elements/{fides_key} - Update an element

DELETE /taxonomies/{taxonomy_type}/elements/{fides_key} - Delete an element

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@eastandwestwind eastandwestwind requested a review from a team as a code owner October 23, 2025 15:11
@eastandwestwind eastandwestwind requested review from adamsachs and removed request for a team October 23, 2025 15:11
@vercel
Copy link

vercel bot commented Oct 23, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ready Ready Preview Comment Oct 29, 2025 11:35pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
fides-privacy-center Ignored Ignored Oct 29, 2025 11:35pm

greptile-apps[bot]

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.40%. Comparing base (9968765) to head (f5173e9).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6824      +/-   ##
==========================================
- Coverage   87.40%   87.40%   -0.01%     
==========================================
  Files         520      520              
  Lines       33920    33918       -2     
  Branches     3899     3899              
==========================================
- Hits        29648    29646       -2     
  Misses       3415     3415              
  Partials      857      857              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eastandwestwind eastandwestwind added this pull request to the merge queue Oct 30, 2025
Merged via the queue into main with commit a2d99e7 Oct 30, 2025
74 checks passed
@eastandwestwind eastandwestwind deleted the ENG-1086 branch October 30, 2025 13:26
adamsachs pushed a commit that referenced this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants