-
Notifications
You must be signed in to change notification settings - Fork 84
ENG-1086: Updates legacy taxonomy consts for custom taxonomy API #6824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6824 +/- ##
==========================================
- Coverage 87.40% 87.40% -0.01%
==========================================
Files 520 520
Lines 33920 33918 -2
Branches 3899 3899
==========================================
- Hits 29648 29646 -2
Misses 3415 3415
Partials 857 857 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ffa2c25 to
d139421
Compare
570706a to
3d5cfe5
Compare
galvana
approved these changes
Oct 29, 2025
adamsachs
pushed a commit
that referenced
this pull request
Nov 3, 2025
Co-authored-by: Adrian Galvan <adrian@ethyca.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket ENG-1086
❗ Please test alongside the Fidesplus PR https://github.com/ethyca/fidesplus/pull/2677
Description Of Changes
Updates legacy taxonomy consts for custom taxonomy API work.
Our legacy taxonomies are auto-inserted into the DB on server start. these include:
We have to ensure any time we need to check / access legacy taxonomies, we use the fides_key instead of the resource type. I've also updated the const to include
system_group.Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works