Skip to content

Conversation

@gilluminate
Copy link
Contributor

This reverts commit 580162f.

@vercel
Copy link

vercel bot commented Oct 23, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ready Ready Preview Comment Oct 23, 2025 6:27pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
fides-privacy-center Ignored Ignored Oct 23, 2025 6:27pm

@Kelsey-Ethyca Kelsey-Ethyca marked this pull request as ready for review October 23, 2025 18:27
@Kelsey-Ethyca Kelsey-Ethyca requested a review from a team as a code owner October 23, 2025 18:27
@Kelsey-Ethyca Kelsey-Ethyca requested review from eastandwestwind and removed request for a team October 23, 2025 18:27
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

This PR reverts the sticky header and action bar implementation from PR #6813, restoring the previous scrolling behavior for full-page tables.

Key changes reverted:

  • Removed sticky table header configuration (sticky: { offsetHeader: 40 }) from multiple table hooks
  • Removed sticky positioning classes from action bars (search/filter controls)
  • Restored FixedLayout usage instead of Layout for pages with full-page tables
  • Simplified LinkCell and ListExpandableCell components by removing containerProps parameter
  • Restored absolute positioning for AddSystemsMenu button
  • Updated Cypress test expectations to include scrollIntoView checks

Impact:
The revert cleanly undoes all sticky header functionality, returning tables to standard scroll behavior where headers and action bars scroll with content rather than remaining fixed at the top of the viewport.

Confidence Score: 5/5

  • This revert is safe to merge with no identified issues
  • This is a clean revert that properly undoes all changes from PR #6813. The diff shows exact inversions of the original changes with no partial reversions or lingering modifications. All affected files are consistently reverted to their pre-sticky-header state.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
clients/admin-ui/src/features/common/table/cells/LinkCell.tsx 5/5 Removed containerProps parameter and Flex wrapper, simplified component structure
clients/admin-ui/src/features/common/table/cells/ListExpandableCell.tsx 5/5 Removed containerProps parameter and simplified layout for expandable list cells
clients/admin-ui/src/features/system/AddSystemsMenu.tsx 5/5 Restored absolute positioning with right-8 top-8 classes for button placement
clients/admin-ui/src/pages/systems/index.tsx 5/5 Switched from Layout back to FixedLayout, removed isSticky prop and mainProps

Sequence Diagram

sequenceDiagram
    participant User
    participant Page as Page Component
    participant Table as Table Component
    participant Cell as Cell Components
    
    Note over Page,Cell: Before Revert (Sticky Headers)
    User->>Page: View page with table
    Page->>Page: Apply Layout with mainProps
    Page->>Table: Render with sticky: {offsetHeader: 40}
    Table->>Cell: Render with containerProps
    Cell->>Cell: Apply Flex wrapper with styling
    Note over Table: Headers stick on scroll
    Note over Page: Action bar sticks on scroll
    
    Note over Page,Cell: After Revert (Normal Scroll)
    User->>Page: View page with table
    Page->>Page: Apply FixedLayout
    Page->>Table: Render without sticky config
    Table->>Cell: Render without containerProps
    Cell->>Cell: Direct rendering without wrapper
    Note over Table: Headers scroll normally
    Note over Page: Action bar scrolls normally
Loading

17 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@gilluminate gilluminate enabled auto-merge October 23, 2025 18:32
@gilluminate gilluminate added this pull request to the merge queue Oct 23, 2025
Merged via the queue into main with commit 25c0ca4 Oct 23, 2025
45 of 46 checks passed
@gilluminate gilluminate deleted the gill/ENG-1748/column-headers-getting branch October 23, 2025 18:48
@greptile-apps greptile-apps bot mentioned this pull request Oct 30, 2025
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants