-
Notifications
You must be signed in to change notification settings - Fork 84
Revert "Implement sticky column headers and action bars for "full-page" tables (#6813)" #6826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Greptile Summary
This PR reverts the sticky header and action bar implementation from PR #6813, restoring the previous scrolling behavior for full-page tables.
Key changes reverted:
- Removed sticky table header configuration (
sticky: { offsetHeader: 40 }) from multiple table hooks - Removed sticky positioning classes from action bars (search/filter controls)
- Restored
FixedLayoutusage instead ofLayoutfor pages with full-page tables - Simplified
LinkCellandListExpandableCellcomponents by removingcontainerPropsparameter - Restored absolute positioning for
AddSystemsMenubutton - Updated Cypress test expectations to include scrollIntoView checks
Impact:
The revert cleanly undoes all sticky header functionality, returning tables to standard scroll behavior where headers and action bars scroll with content rather than remaining fixed at the top of the viewport.
Confidence Score: 5/5
- This revert is safe to merge with no identified issues
- This is a clean revert that properly undoes all changes from PR #6813. The diff shows exact inversions of the original changes with no partial reversions or lingering modifications. All affected files are consistently reverted to their pre-sticky-header state.
- No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| clients/admin-ui/src/features/common/table/cells/LinkCell.tsx | 5/5 | Removed containerProps parameter and Flex wrapper, simplified component structure |
| clients/admin-ui/src/features/common/table/cells/ListExpandableCell.tsx | 5/5 | Removed containerProps parameter and simplified layout for expandable list cells |
| clients/admin-ui/src/features/system/AddSystemsMenu.tsx | 5/5 | Restored absolute positioning with right-8 top-8 classes for button placement |
| clients/admin-ui/src/pages/systems/index.tsx | 5/5 | Switched from Layout back to FixedLayout, removed isSticky prop and mainProps |
Sequence Diagram
sequenceDiagram
participant User
participant Page as Page Component
participant Table as Table Component
participant Cell as Cell Components
Note over Page,Cell: Before Revert (Sticky Headers)
User->>Page: View page with table
Page->>Page: Apply Layout with mainProps
Page->>Table: Render with sticky: {offsetHeader: 40}
Table->>Cell: Render with containerProps
Cell->>Cell: Apply Flex wrapper with styling
Note over Table: Headers stick on scroll
Note over Page: Action bar sticks on scroll
Note over Page,Cell: After Revert (Normal Scroll)
User->>Page: View page with table
Page->>Page: Apply FixedLayout
Page->>Table: Render without sticky config
Table->>Cell: Render without containerProps
Cell->>Cell: Direct rendering without wrapper
Note over Table: Headers scroll normally
Note over Page: Action bar scrolls normally
17 files reviewed, no comments
This reverts commit 580162f.