Skip to content

Conversation

@gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Oct 23, 2025

Ticket ENG-1754

Description Of Changes

Routes got changed, this is the one that slipped through the cracks

Code Changes

  • route to correct URL

Steps to Confirm

  1. Run a scan
  2. Go to a system in the Action Center, and ‘Add All’
  3. Verify you don't end up back the home page, but that you end up back at the monitor page

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link

vercel bot commented Oct 23, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ready Ready Preview Comment Oct 23, 2025 8:50pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
fides-privacy-center Ignored Ignored Oct 23, 2025 8:50pm

@gilluminate gilluminate marked this pull request as ready for review October 23, 2025 20:31
@gilluminate gilluminate requested a review from a team as a code owner October 23, 2025 20:31
@gilluminate gilluminate requested review from lucanovera and removed request for a team October 23, 2025 20:31
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

Fixed an incorrect redirect route that was causing users to end up on the home page instead of the monitor page after adding all assets from a system in the Action Center.

Key Changes:

  • Changed redirect from string concatenation ${ACTION_CENTER_ROUTE}/${monitorId} to proper Next.js router object with pathname and query parameters
  • Imported ACTION_CENTER_WEBSITE_MONITOR_ROUTE constant to use the correct route pattern
  • Added proper URL encoding for the monitorId query parameter to match Next.js conventions

The previous route was constructing /data-discovery/action-center/${monitorId} which doesn't correspond to any existing page. The correct route is /data-discovery/action-center/website/[monitorId] which is now properly used via the router object pattern.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk - it's a straightforward bug fix
  • The change fixes a clear routing bug where an invalid URL pattern was being used. The fix uses the proper Next.js router pattern with pathname and query parameters, follows existing conventions in the codebase (using the ACTION_CENTER_WEBSITE_MONITOR_ROUTE constant), and includes proper URL encoding. The change is minimal, focused, and addresses the exact issue described in the PR description
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
clients/admin-ui/src/pages/data-discovery/action-center/website/[monitorId]/[systemId]/index.tsx 5/5 Fixed redirect route to use correct pathname with query params instead of invalid string concatenation

Sequence Diagram

sequenceDiagram
    participant User
    participant MonitorResultAssets as MonitorResultAssets Page
    participant Query as useGetDiscoveredSystemAggregateQuery
    participant Router as Next.js Router
    participant MonitorPage as Website Monitor Page

    User->>MonitorResultAssets: Navigate to system assets page
    MonitorResultAssets->>Query: Fetch system results for monitorId + systemId
    Query-->>MonitorResultAssets: Return systemResults
    
    alt systemResults.items.length === 0
        MonitorResultAssets->>Router: router.push({ pathname, query: { monitorId } })
        Router->>MonitorPage: Redirect to /action-center/website/[monitorId]
        MonitorPage-->>User: Display monitor page
    else systemResults.items.length > 0
        MonitorResultAssets-->>User: Display DiscoveredAssetsTable
    end
Loading

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix works correctly, I clicked add all, saw the success message and got redirected to the monitor page.

clicked add all:
Captura de pantalla 2025-10-23 a la(s) 5 39 19 p  m

redirected:
Captura de pantalla 2025-10-23 a la(s) 5 39 26 p  m

@gilluminate gilluminate added this pull request to the merge queue Oct 23, 2025
Merged via the queue into main with commit f6b5ebf Oct 23, 2025
46 checks passed
@gilluminate gilluminate deleted the gill/ENG-1754/redirect-url-is-pointing-to branch October 23, 2025 21:36
gilluminate added a commit that referenced this pull request Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants