Skip to content

Conversation

@speaker-ender
Copy link
Contributor

Description Of Changes

Update description size in tray per the suggestion of @jack-gale-ethyca

Code Changes

Simple update of description size attribute

Steps to Confirm

  1. Open a details drawer for a field
  2. Confirm that the description size looks correct

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link

vercel bot commented Oct 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ready Ready Preview Comment Oct 24, 2025 3:57pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
fides-privacy-center Ignored Ignored Oct 24, 2025 3:57pm

@speaker-ender speaker-ender marked this pull request as ready for review October 24, 2025 00:11
@speaker-ender speaker-ender requested a review from a team as a code owner October 24, 2025 00:11
@speaker-ender speaker-ender requested review from gilluminate and jack-gale-ethyca and removed request for a team October 24, 2025 00:11
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

Updated the description size in the details drawer for field resources to use a smaller, more compact display. Also refactored a ternary expression to use optional chaining for cleaner code.

Changes:

  • Refactored title prop to use optional chaining (resource?.name ?? null) instead of ternary operator for better readability
  • Added size="small" prop to the Descriptions component to make the description section more compact in the details drawer

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The changes are minimal and straightforward: a simple UI styling adjustment (size prop) and a code quality improvement (optional chaining). Both changes are non-breaking, follow modern JavaScript patterns, and align with the PR description. The size="small" prop is a standard Ant Design Descriptions component prop, and the optional chaining refactor improves code readability without changing behavior.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/page.tsx 5/5 Updated DetailsDrawer title to use optional chaining and added size="small" prop to Descriptions component for better UI density

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@speaker-ender speaker-ender force-pushed the refactor/description-size branch from 93c5336 to c8a6a4b Compare October 24, 2025 15:53
@speaker-ender speaker-ender added this pull request to the merge queue Oct 24, 2025
Merged via the queue into main with commit e280657 Oct 24, 2025
46 checks passed
@speaker-ender speaker-ender deleted the refactor/description-size branch October 24, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants