Skip to content

Conversation

@speaker-ender
Copy link
Contributor

Description Of Changes

Bothering me that no-results would flash on load and this is a simple fix.
Also makes the list full height to reduce some jumping

Code Changes

  • Added loading indicator when fetching fields
  • Added h-full class to field list so that it fills the provided area

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link

vercel bot commented Oct 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ready Ready Preview Comment Oct 24, 2025 3:57pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
fides-privacy-center Ignored Ignored Oct 24, 2025 3:57pm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

Added loading indicator to the fields list using Ant Design's built-in loading prop and applied h-full class to make the list fill the available height.

  • Prevents "no results" message from flashing during initial load
  • Reduces layout jumping by ensuring the list maintains full height
  • Uses isFetching from the RTK Query hook to track loading state

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The changes are minimal and straightforward - adding a loading indicator and height styling to improve UX. Uses standard Ant Design List component props without any logic changes
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/page.tsx 5/5 Added loading indicator and full-height styling to field list - simple UX improvement with no logical issues

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@speaker-ender speaker-ender force-pushed the feat/field-list-loading-indicator branch from 490600b to 7c491e0 Compare October 24, 2025 15:53
@speaker-ender speaker-ender added this pull request to the merge queue Oct 24, 2025
Merged via the queue into main with commit ef58d40 Oct 24, 2025
46 checks passed
@speaker-ender speaker-ender deleted the feat/field-list-loading-indicator branch October 24, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants