-
Notifications
You must be signed in to change notification settings - Fork 84
feat: promoting status support #6838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Greptile Summary
This PR adds support for a new "Promoting" status in the FE data discovery and detection action center. The changes map the backend promoting diff status to a distinct "Promoting" resource status label instead of the generic "In Review" status.
Key Changes:
- Added "Promoting" as a new
ResourceStatusLabelin the status constants - Updated
DIFF_TO_RESOURCE_STATUSandMAP_DIFF_STATUS_TO_RESOURCE_STATUS_LABELto mappromotingdiff status to "Promoting" (previously mapped to "In Review") - Added "Promoting" to
AVAILABLE_ACTIONSwith an empty actions array (no actions available in this state) - Alphabetized
FIELD_ACTION_LABELobject keys to satisfy linter requirements
The implementation is straightforward and consistent with existing status handling patterns. The "Promoting" status correctly has no available actions, which aligns with it being a transitional state.
Confidence Score: 5/5
- This PR is safe to merge with minimal risk
- The changes are minimal, well-scoped, and follow existing patterns in the codebase. The new "Promoting" status is properly integrated into all relevant constant mappings, and the backend already supports the
promotingdiff status. The empty actions array for "Promoting" status is appropriate for a transitional state. No logic errors or security concerns identified. - No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/FieldActions.const.tsx | 5/5 | Added Promoting status to AVAILABLE_ACTIONS with no available actions, and alphabetized the FIELD_ACTION_LABEL object keys |
| clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/MonitorFields.const.ts | 5/5 | Added Promoting to the RESOURCE_STATUS array and updated the promoting diff status mapping from "In Review" to "Promoting" |
2 files reviewed, no comments
0837d24 to
15e24af
Compare
15e24af to
0b3a24a
Compare
chore: fighting linter to sort correctl chore: rename label chore: still renaming label
0b3a24a to
dfe58f8
Compare
Description Of Changes
Adding "Promoting" as a status in the FE
Code Changes
Adding "Promoting" as a resource status and mapping to the "promoting" diff status returned from the BE
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works