Skip to content

Conversation

@speaker-ender
Copy link
Contributor

Description Of Changes

Adding "Promoting" as a status in the FE

Code Changes

Adding "Promoting" as a resource status and mapping to the "promoting" diff status returned from the BE

Steps to Confirm

  1. Go to the new classifier screen
  2. Click confirm button on a field
  3. Validate that the status changes to "Promoting" instead of "In Review"

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link

vercel bot commented Oct 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ready Ready Preview Comment Oct 24, 2025 5:02pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
fides-privacy-center Ignored Ignored Oct 24, 2025 5:02pm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

This PR adds support for a new "Promoting" status in the FE data discovery and detection action center. The changes map the backend promoting diff status to a distinct "Promoting" resource status label instead of the generic "In Review" status.

Key Changes:

  • Added "Promoting" as a new ResourceStatusLabel in the status constants
  • Updated DIFF_TO_RESOURCE_STATUS and MAP_DIFF_STATUS_TO_RESOURCE_STATUS_LABEL to map promoting diff status to "Promoting" (previously mapped to "In Review")
  • Added "Promoting" to AVAILABLE_ACTIONS with an empty actions array (no actions available in this state)
  • Alphabetized FIELD_ACTION_LABEL object keys to satisfy linter requirements

The implementation is straightforward and consistent with existing status handling patterns. The "Promoting" status correctly has no available actions, which aligns with it being a transitional state.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are minimal, well-scoped, and follow existing patterns in the codebase. The new "Promoting" status is properly integrated into all relevant constant mappings, and the backend already supports the promoting diff status. The empty actions array for "Promoting" status is appropriate for a transitional state. No logic errors or security concerns identified.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/FieldActions.const.tsx 5/5 Added Promoting status to AVAILABLE_ACTIONS with no available actions, and alphabetized the FIELD_ACTION_LABEL object keys
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/MonitorFields.const.ts 5/5 Added Promoting to the RESOURCE_STATUS array and updated the promoting diff status mapping from "In Review" to "Promoting"

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

chore: fighting linter to sort correctl

chore: rename label

chore: still renaming label
@speaker-ender speaker-ender force-pushed the feat/promoting-status-support branch from 0b3a24a to dfe58f8 Compare October 24, 2025 16:58
@speaker-ender speaker-ender added this pull request to the merge queue Oct 24, 2025
Merged via the queue into main with commit 2034b5e Oct 24, 2025
46 checks passed
@speaker-ender speaker-ender deleted the feat/promoting-status-support branch October 24, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants