Skip to content

Conversation

@gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Oct 24, 2025

The previous filter in PR #6830 incorrectly excluded such dual-purpose vendors from the legitimate interests tab, which this PR corrects.

@gilluminate gilluminate requested a review from a team as a code owner October 24, 2025 20:15
@gilluminate gilluminate requested review from eastandwestwind and removed request for a team October 24, 2025 20:15
@vercel
Copy link

vercel bot commented Oct 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ignored Ignored Oct 24, 2025 8:15pm
fides-privacy-center Ignored Ignored Oct 24, 2025 8:15pm

@gilluminate gilluminate requested review from NevilleS and removed request for eastandwestwind October 24, 2025 20:15
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

This PR fixes the vendor filtering logic for the legitimate interests (LI) tab by removing the !v.isConsent condition from the legintGvlVendors filter. This change correctly restores vendors that have both consent and legitimate interest legal bases to the LI tab.

Key changes:

  • Removed && !v.isConsent from the legintGvlVendors filter on line 276
  • Vendors with legitimate interest purposes will now appear in the LI tab regardless of whether they also have consent purposes

Context:
According to the TCF (Transparency and Consent Framework) specification, vendors can legitimately have multiple legal bases for processing data. A vendor may use consent for some purposes and legitimate interest for others. The previous filter in PR #6830 incorrectly excluded such dual-purpose vendors from the legitimate interests tab, which this PR corrects.

Confidence Score: 5/5

  • This PR is safe to merge - it's a minimal, well-targeted fix that corrects vendor filtering logic
  • The change is a simple one-line fix that removes an overly restrictive filter condition. The logic is correct: vendors with legitimate interest should appear in the LI tab regardless of whether they also have consent purposes. This aligns with TCF specifications where vendors can have multiple legal bases.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
clients/fides-js/src/components/tcf/TcfVendors.tsx 5/5 Restores vendors with both consent and legitimate interest purposes to the legitimate interest tab by removing the !v.isConsent filter condition. This correctly allows dual-purpose vendors to appear in the LI tab.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@gilluminate gilluminate enabled auto-merge October 24, 2025 20:30
@gilluminate gilluminate added this pull request to the merge queue Oct 24, 2025
Merged via the queue into main with commit 1214369 Oct 24, 2025
42 checks passed
@gilluminate gilluminate deleted the gill/ENG-1755/unexpected-behavior-for-tcf-followup branch October 24, 2025 20:42
gilluminate added a commit that referenced this pull request Oct 24, 2025
Restore isConsent to LI (#6840)
JadeCara pushed a commit that referenced this pull request Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants