Skip to content

Conversation

@vcruces
Copy link
Contributor

@vcruces vcruces commented Oct 29, 2025

Ticket ENG-1796

Description Of Changes

This PR updates the frontend to handle optional confidence score fields in datastore monitor updates and removes the classified_manually field that is no longer needed.

⚠️ These changes align with backend updates in fidesplus branch ENG-1796-confidence-score.

The classified_low_confidence and classified_high_confidence fields are now optional and nullable, as they may not always be present in monitor update responses. The classified_manually classification type has been removed from the system.

Code Changes

  • Updated DatastoreMonitorUpdates TypeScript type to make classified_low_confidence and classified_high_confidence optional and nullable
  • Removed classified_manually field from the monitor updates type definition
  • Added null check in MonitorResultDescription.tsx to handle nullable count values before filtering
  • Removed classified_manually from the MONITOR_UPDATES_TO_IGNORE constants array
  • Updated test fixture aggregate-results.json to remove the classified_manually field

Steps to Confirm

  1. Run the admin UI and navigate to the action center (enable the alpha flag)
  2. Verify that monitor results display correctly without errors
  3. Verify that the UI handles missing confidence score fields gracefully

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link

vercel bot commented Oct 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ready Ready Preview Comment Oct 29, 2025 6:39pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
fides-privacy-center Ignored Ignored Oct 29, 2025 6:39pm

@vcruces vcruces marked this pull request as ready for review October 29, 2025 18:17
@vcruces vcruces requested a review from a team as a code owner October 29, 2025 18:17
@vcruces vcruces requested review from gilluminate and speaker-ender and removed request for a team October 29, 2025 18:17
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

This PR updates the frontend to handle optional confidence score fields (classified_low_confidence and classified_high_confidence) in datastore monitor updates, aligning with backend API changes. The classified_manually field has been removed from the type definition, constants, and test fixtures.

Key changes:

  • Type definition updated to make confidence fields optional and nullable
  • Added proper null checking in MonitorResultDescription.tsx before filtering and formatting
  • Removed classified_manually from ignored fields array
  • Updated test fixture to match new type structure

The implementation correctly handles the nullable fields by filtering out null/undefined values before processing, and uses a non-null assertion operator after the filter, which is safe since the filter ensures only non-null values pass through.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are straightforward type updates with proper null handling. The null check is correctly placed in the filter before any value usage, and the non-null assertion is safe after filtering. All references to the removed field have been cleaned up, and test fixtures have been updated accordingly.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
clients/admin-ui/src/types/api/models/DatastoreMonitorUpdates.ts 5/5 Made confidence fields optional/nullable and removed classified_manually field - aligns with backend API changes
clients/admin-ui/src/features/data-discovery-and-detection/action-center/MonitorResultDescription.tsx 5/5 Added null check in filter to handle optional confidence fields - correctly uses non-null assertion after filtering

4 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@vcruces vcruces requested a review from gilluminate October 29, 2025 18:35
@gilluminate gilluminate mentioned this pull request Oct 29, 2025
18 tasks
@vcruces vcruces added this pull request to the merge queue Oct 29, 2025
Merged via the queue into main with commit fe2e505 Oct 29, 2025
46 checks passed
@vcruces vcruces deleted the ENG-1796 branch October 29, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants