-
Notifications
You must be signed in to change notification settings - Fork 84
ENG-1404 Create Duplicate Group table #6881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JadeCara
merged 54 commits into
main
from
duplicate_group-ENG-1404-be-implement-ability-to-sort-filter-duplicate-dsr-records
Oct 30, 2025
Merged
ENG-1404 Create Duplicate Group table #6881
JadeCara
merged 54 commits into
main
from
duplicate_group-ENG-1404-be-implement-ability-to-sort-filter-duplicate-dsr-records
Oct 30, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-duplicate-dsr-records-model
…-duplicate-dsr-records-model
…-duplicate-dsr-records-model
…-duplicate-dsr-records-model
…-duplicate-dsr-records-model
…-duplicate-dsr-records-model
…dsr-records-model' into duplicate_group-ENG-1404-be-implement-ability-to-sort-filter-duplicate-dsr-records
18 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6881 +/- ##
==========================================
+ Coverage 87.40% 87.41% +0.01%
==========================================
Files 521 522 +1
Lines 33944 33981 +37
Branches 3899 3900 +1
==========================================
+ Hits 29668 29705 +37
Misses 3419 3419
Partials 857 857 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Base automatically changed from
ENG-1404-be-implement-ability-to-sort-filter-duplicate-dsr-records-model
to
main
October 29, 2025 22:03
…y-to-sort-filter-duplicate-dsr-records
18 tasks
…y-to-sort-filter-duplicate-dsr-records
…y-to-sort-filter-duplicate-dsr-records
thabofletcher
approved these changes
Oct 30, 2025
…y-to-sort-filter-duplicate-dsr-records
…y-to-sort-filter-duplicate-dsr-records
adamsachs
pushed a commit
that referenced
this pull request
Nov 3, 2025
Co-authored-by: Jade Wibbels <jade@ethyca.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket ENG-1404
Description Of Changes
🎯 Fides must provide a way for privacy admins to quickly identify and surface in the request manager UI privacy requests which are likely duplicates submitted by the same user over a period of time.
This PR adds a table for duplicate group id management. If an admin wants to update the grouping config we dont want to suddenly mark duplicates that were previously found as not duplicates. We do want to know which duplicates were located under which configurations.
Example:
If we want to change the time window or the identity fields to match that should create its own unique group id. Instead of looking for which group an duplicate belongs to we can also deterministically find the group id using the rules and hashed values.
Code Changes
DuplicateGroupand associated helper functionsPrivacyRequestrelationshipsSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works