Skip to content

Conversation

@gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Oct 31, 2025

Ticket ENG-1787

Description of changes

Restricted tree node selection in the monitor schema explorer to only allow classifiable resource types (Schema, Table, Endpoint, and Field).

Code changes

  • Added classifyable property to CustomTreeDataNode interface to track which nodes can be classified
  • Updated mapResponseToTreeData to mark only Schema, Table, Endpoint, and Field resource types as classifiable
  • Modified handleSelect to filter out non-classifiable nodes from selection

Steps to confirm

  1. Attempt to select various node types (Database, Schema, Table, etc.)
  2. Confirm the classify button only appears when classifiable nodes are selected

@vercel
Copy link

vercel bot commented Oct 31, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ready Ready Preview Comment Nov 3, 2025 10:24pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
fides-privacy-center Ignored Ignored Nov 3, 2025 10:24pm

@gilluminate gilluminate marked this pull request as ready for review October 31, 2025 18:32
@gilluminate gilluminate requested a review from a team as a code owner October 31, 2025 18:32
@gilluminate gilluminate requested review from jpople and speaker-ender and removed request for a team and jpople October 31, 2025 18:32
greptile-apps[bot]

This comment was marked as outdated.

@gilluminate
Copy link
Contributor Author

@greptile

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

This PR restricts monitor tree node selection to only classifiable resource types (Schema, Table, Endpoint, and Field) by adding a classifyable property to tree nodes and filtering selections in the handleSelect handler.

Key changes:

  • Added classifyable boolean property to CustomTreeDataNode interface in types.d.ts:18
  • Modified mapResponseToTreeData to mark Schema, Table, Endpoint, and Field resource types as classifiable in MonitorTree.tsx:66-71
  • Updated handleSelect to filter selected nodes, keeping only those marked as classifiable in MonitorTree.tsx:529-537

Implementation note:
The logic error identified in the previous comment was fixed in commit 2c4919f8c. The initial implementation incorrectly used nodes.node (single node) instead of info.selectedNodes (array of all selected nodes). The current implementation correctly iterates through all selected nodes and filters by the classifyable property.

Confidence Score: 5/5

  • This PR is safe to merge - implements straightforward filtering logic with no security concerns
  • The implementation is clean and correct. The initial logic error was already fixed in commit 2c4919f. The change adds a simple boolean property to track classifiable nodes and filters selections appropriately. No security vulnerabilities, performance issues, or breaking changes introduced.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/types.d.ts 5/5 Added classifyable property to CustomTreeDataNode interface - straightforward type extension
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/MonitorTree.tsx 5/5 Correctly implements classifiable node filtering in tree selection - logic error was fixed in commit 2c4919f

3 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@gilluminate gilluminate force-pushed the gill/ENG-1787/fe-hide-option-to-classify branch from 2c4919f to 7363381 Compare November 3, 2025 22:19
@gilluminate gilluminate enabled auto-merge November 3, 2025 22:20
@gilluminate gilluminate added this pull request to the merge queue Nov 3, 2025
Merged via the queue into main with commit dd82881 Nov 3, 2025
47 checks passed
@gilluminate gilluminate deleted the gill/ENG-1787/fe-hide-option-to-classify branch November 3, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants