-
Notifications
You must be signed in to change notification settings - Fork 84
Restrict monitor tree selection to classifiable resources #6900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Greptile Summary
This PR restricts monitor tree node selection to only classifiable resource types (Schema, Table, Endpoint, and Field) by adding a classifyable property to tree nodes and filtering selections in the handleSelect handler.
Key changes:
- Added
classifyableboolean property toCustomTreeDataNodeinterface intypes.d.ts:18 - Modified
mapResponseToTreeDatato mark Schema, Table, Endpoint, and Field resource types as classifiable inMonitorTree.tsx:66-71 - Updated
handleSelectto filter selected nodes, keeping only those marked as classifiable inMonitorTree.tsx:529-537
Implementation note:
The logic error identified in the previous comment was fixed in commit 2c4919f8c. The initial implementation incorrectly used nodes.node (single node) instead of info.selectedNodes (array of all selected nodes). The current implementation correctly iterates through all selected nodes and filters by the classifyable property.
Confidence Score: 5/5
- This PR is safe to merge - implements straightforward filtering logic with no security concerns
- The implementation is clean and correct. The initial logic error was already fixed in commit 2c4919f. The change adds a simple boolean property to track classifiable nodes and filters selections appropriately. No security vulnerabilities, performance issues, or breaking changes introduced.
- No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/types.d.ts | 5/5 | Added classifyable property to CustomTreeDataNode interface - straightforward type extension |
| clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/MonitorTree.tsx | 5/5 | Correctly implements classifiable node filtering in tree selection - logic error was fixed in commit 2c4919f |
3 files reviewed, no comments
2c4919f to
7363381
Compare
Ticket ENG-1787
Description of changes
Restricted tree node selection in the monitor schema explorer to only allow classifiable resource types (Schema, Table, Endpoint, and Field).
Code changes
classifyableproperty toCustomTreeDataNodeinterface to track which nodes can be classifiedmapResponseToTreeDatato mark only Schema, Table, Endpoint, and Field resource types as classifiablehandleSelectto filter out non-classifiable nodes from selectionSteps to confirm