Skip to content

Conversation

@speaker-ender
Copy link
Contributor

@speaker-ender speaker-ender commented Nov 3, 2025

Ticket ENG-1839

Description Of Changes

Syncs the logic for ASSIGN_CATEGORIES action with the BE ACTION_ALLOWED_STATUSES enum.
Ideally this logic would be entirely determined by the BE.

Code Changes

  • Updating AVAILABLE_ACTIONS enum to more closely align with the ACTION_ALLOWED_STATUSES enum on the backend.

Steps to Confirm

  1. View field items in each of the different diff states on the new classification screen
  2. Confirm that assigning categories is only enabled or disabled for the expected states

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@speaker-ender speaker-ender requested a review from a team as a code owner November 3, 2025 15:30
@vercel
Copy link

vercel bot commented Nov 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ready Ready Preview Comment Nov 3, 2025 4:21pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
fides-privacy-center Ignored Ignored Nov 3, 2025 4:21pm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

Enables data category assignment for fields in "In Review" and "Approved" statuses by adding ASSIGN_CATEGORIES to their allowed actions.

  • Updated AVAILABLE_ACTIONS object to include FieldActionType.ASSIGN_CATEGORIES for "In Review" status (alongside existing classify, mute, approve, and promote actions)
  • Updated AVAILABLE_ACTIONS object to include FieldActionType.ASSIGN_CATEGORIES for "Approved" status (alongside existing mute and promote actions)

This change aligns the frontend logic with backend status restrictions, allowing users to manually assign data categories to resources that are in these intermediate states rather than forcing them through the classification workflow first.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is a simple, focused addition to an existing configuration object that controls UI behavior. It adds a single action type to two status arrays without modifying any logic, types, or backend behavior. The change follows the existing pattern and is well-contained.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/FieldActions.const.tsx 5/5 Added ASSIGN_CATEGORIES action to "In Review" and "Approved" statuses to enable category assignment in those states

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@speaker-ender speaker-ender changed the title fix: data category select logic fix: data category select logic [ENG- Nov 3, 2025
@speaker-ender speaker-ender changed the title fix: data category select logic [ENG- fix: data category select logic [ENG-1839] Nov 3, 2025
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@speaker-ender speaker-ender added this pull request to the merge queue Nov 3, 2025
Merged via the queue into main with commit 19ad1f8 Nov 3, 2025
47 checks passed
@speaker-ender speaker-ender deleted the fix/data-category-select-logic branch November 3, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants