-
Notifications
You must be signed in to change notification settings - Fork 84
Rename welcome.html in DSR reports #6923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greptile Overview
Greptile Summary
Renamed the main DSR report entry point file from welcome.html to clickme.html throughout the codebase.
Key changes:
- Renamed template file from
welcome.htmltoclickme.html - Updated
dsr_report_builder.pyto reference the new filename in code comments, file generation, and template references - Updated navigation links in
attachments_index.htmlanddataset_index.htmlto point toclickme.html - Updated all test files (8 test files) to reference
clickme.htmlin assertions and mock data - Applied consistent HTML formatting improvements (indentation, self-closing tags) across template files
The rename is complete and comprehensive, with all references updated across source code, templates, and tests. No functional changes were introduced - this is purely a renaming refactor.
Confidence Score: 5/5
- This PR is safe to merge with no risk
- This is a straightforward rename operation with comprehensive test coverage updates. All references to
welcome.htmlhave been successfully replaced withclickme.htmlacross the entire codebase (verified by grep search). The change is purely cosmetic/naming and includes no functional modifications. The accompanying formatting improvements to HTML templates are minimal and safe. - No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| src/fides/api/service/privacy_request/dsr_package/dsr_report_builder.py | 5/5 | Updated documentation and references from welcome.html to clickme.html for the main DSR report index page |
| src/fides/api/service/privacy_request/dsr_package/templates/clickme.html | 5/5 | New template file renamed from welcome.html with consistent formatting improvements |
| src/fides/api/service/privacy_request/dsr_package/templates/attachments_index.html | 5/5 | Updated back link reference from welcome.html to clickme.html with formatting improvements |
| src/fides/api/service/privacy_request/dsr_package/templates/dataset_index.html | 5/5 | Updated back link reference from welcome.html to clickme.html with formatting improvements |
12 files reviewed, no comments
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6923 +/- ##
=======================================
Coverage 87.32% 87.32%
=======================================
Files 525 525
Lines 34417 34417
Branches 3960 3960
=======================================
Hits 30054 30054
Misses 3500 3500
Partials 863 863 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adamsachs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code changes look good to me, pretty straightforward!
i can't say i was able to get the full workflow set up locally (just environmental issues getting storage and messaging notifications properly configured), but i did at least confirm that i've got a valid clickme.html in my local storage.
if you've confirmed the 'real' e2e with a messaging template and that it integrates well with cloud storage and our emails, etc. - then let's go ahead and get this merged. if you've got any doubts on e2e testing, let's just make sure we confirm it in a deployed env (e.g. nightly) 👍
Ticket ENG-1419
Description Of Changes
Renames welcome.html to clickme.html in DSR reports.
Steps to Confirm
Setup:
Test:
clickme.htmland contain the "your requested data" packagePre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works