Skip to content

Conversation

@jpople
Copy link
Contributor

@jpople jpople commented Nov 5, 2025

Ticket ENG-1419

Description Of Changes

Renames welcome.html to clickme.html in DSR reports.

Steps to Confirm

Setup:

  1. Configure a messaging provider and storage source
  2. Enable property specific messaging in your .env if you don't already have it
  3. In /notifications/templates, toggle on "Access request completed"

Test:

  1. Make and approve an access request to your email
  2. Should receive an email with a download link
  3. Click the download link
  4. Inside the zip, file should be called clickme.html and contain the "your requested data" package

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link

vercel bot commented Nov 5, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ready Ready Preview Comment Nov 11, 2025 8:36pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
fides-privacy-center Ignored Ignored Nov 11, 2025 8:36pm

@jpople jpople marked this pull request as ready for review November 5, 2025 17:01
@jpople jpople requested a review from a team as a code owner November 5, 2025 17:01
@jpople jpople requested review from adamsachs and removed request for a team November 5, 2025 17:01
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

Renamed the main DSR report entry point file from welcome.html to clickme.html throughout the codebase.

Key changes:

  • Renamed template file from welcome.html to clickme.html
  • Updated dsr_report_builder.py to reference the new filename in code comments, file generation, and template references
  • Updated navigation links in attachments_index.html and dataset_index.html to point to clickme.html
  • Updated all test files (8 test files) to reference clickme.html in assertions and mock data
  • Applied consistent HTML formatting improvements (indentation, self-closing tags) across template files

The rename is complete and comprehensive, with all references updated across source code, templates, and tests. No functional changes were introduced - this is purely a renaming refactor.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • This is a straightforward rename operation with comprehensive test coverage updates. All references to welcome.html have been successfully replaced with clickme.html across the entire codebase (verified by grep search). The change is purely cosmetic/naming and includes no functional modifications. The accompanying formatting improvements to HTML templates are minimal and safe.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
src/fides/api/service/privacy_request/dsr_package/dsr_report_builder.py 5/5 Updated documentation and references from welcome.html to clickme.html for the main DSR report index page
src/fides/api/service/privacy_request/dsr_package/templates/clickme.html 5/5 New template file renamed from welcome.html with consistent formatting improvements
src/fides/api/service/privacy_request/dsr_package/templates/attachments_index.html 5/5 Updated back link reference from welcome.html to clickme.html with formatting improvements
src/fides/api/service/privacy_request/dsr_package/templates/dataset_index.html 5/5 Updated back link reference from welcome.html to clickme.html with formatting improvements

12 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.32%. Comparing base (7251636) to head (93a7145).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6923   +/-   ##
=======================================
  Coverage   87.32%   87.32%           
=======================================
  Files         525      525           
  Lines       34417    34417           
  Branches     3960     3960           
=======================================
  Hits        30054    30054           
  Misses       3500     3500           
  Partials      863      863           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes look good to me, pretty straightforward!

i can't say i was able to get the full workflow set up locally (just environmental issues getting storage and messaging notifications properly configured), but i did at least confirm that i've got a valid clickme.html in my local storage.

if you've confirmed the 'real' e2e with a messaging template and that it integrates well with cloud storage and our emails, etc. - then let's go ahead and get this merged. if you've got any doubts on e2e testing, let's just make sure we confirm it in a deployed env (e.g. nightly) 👍

@jpople jpople enabled auto-merge November 7, 2025 16:45
@jpople jpople added this pull request to the merge queue Nov 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 7, 2025
@jpople jpople added this pull request to the merge queue Nov 11, 2025
Merged via the queue into main with commit da6381c Nov 11, 2025
69 checks passed
@jpople jpople deleted the jpople/eng-1419/rename-welcome-html branch November 11, 2025 22:08
jjdaurora pushed a commit that referenced this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants