update keyboard shortcuts button #6928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
gilluminate
force-pushed
the
gill/ENG-1599/keyboard-hotkeys-modal-button
branch
from
5304982 to
63a9429
Compare
lucanovera
approved these changes
Nov 5, 2025
Contributor
lucanovera
left a comment
lucanovera
left a comment
There was a problem hiding this comment.
square icon looks good.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Greptile Overview
Greptile Summary
This PR updates the keyboard shortcuts helper button in the Action Center fields page with three minor UI improvements:
- Changed icon from
Icons.HelptoIcons.Keyboardfor better visual clarity - Removed
type="text"prop from the Button component, defaulting to standard button styling - Updated text from "Show keyboard shortcuts" to "Display keyboard shortcuts" in both the tooltip and aria-label for consistency
Confidence Score: 5/5
- This PR is safe to merge with no risk
- The changes are purely cosmetic UI adjustments to a single button component. The icon change from Help to Keyboard is semantically more appropriate, removing the button type prop is safe as it defaults to standard styling, and the text changes maintain consistency. No logic, functionality, or security concerns are introduced.
- No files require special attention
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/page.tsx | 5/5 | Updated keyboard shortcuts button from Help icon to Keyboard icon, removed type="text" prop, and changed tooltip/aria-label text from "Show" to "Display" |
1 file reviewed, no comments
gilluminate
added a commit
that referenced
this pull request
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor adjustment to the UI