feat: support removals [ENG-1595] #6941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
speaker-ender
force-pushed
the
feat/support-removals--ENG-1595
branch
from
828fcf0 to
0c9595d
Compare
speaker-ender
force-pushed
the
feat/support-removals--ENG-1595
branch
from
0c9595d to
0c40e68
Compare
speaker-ender
force-pushed
the
feat/support-removals--ENG-1595
branch
2 times, most recently
from
b1a7663 to
247079e
Compare
speaker-ender
requested review from
gilluminate
and removed request for
a team
Contributor
Greptile OverviewGreptile SummaryThis PR adds support for removing fields in the action center with proper confirmation workflows. The implementation makes field actions dynamic based on resource status using readonly mapping objects, following best practices. Key Changes:
Issues Found:
Confidence Score: 4/5
Important Files ChangedFile Analysis
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| const [promoteResourcesMutation] = usePromoteResourcesMutation(); | ||
| const [unMuteMonitorResultAssetsMutation] = useUnmuteResourcesMutation(); | ||
| const [updateResourcesCategoryMutation] = useUpdateResourceCategoryMutation(); | ||
| const [prmoteRemovalMutation] = usePromoteRemovalStagedResourcesMutation(); |
Contributor
There was a problem hiding this comment.
syntax: typo: prmoteRemovalMutation missing 'o' - should be promoteRemovalMutation
Suggested change
| const [prmoteRemovalMutation] = usePromoteRemovalStagedResourcesMutation(); | |
| const [promoteRemovalMutation] = usePromoteRemovalStagedResourcesMutation(); |
| }; | ||
|
|
||
| const handlePromoteRemoval = async (urns: string[]) => { | ||
| return prmoteRemovalMutation({ |
Contributor
There was a problem hiding this comment.
syntax: update variable reference after fixing typo on line 60
Suggested change
| return prmoteRemovalMutation({ | |
| return promoteRemovalMutation({ |
speaker-ender
force-pushed
the
feat/support-removals--ENG-1595
branch
from
247079e to
51ccb98
Compare
gilluminate
approved these changes
Nov 11, 2025
Contributor
gilluminate
left a comment
gilluminate
left a comment
There was a problem hiding this comment.
Overall looks good. One grammar fix is needed for when there's only 1 item selected. I did notice during testing that restoring an item will put it in the "confirmed" status. Is that expected?
Comment on lines
181
to
182
| "promote-removals": (targetItemCount: number) => | ||
| `Are you sure you want to remove these ${targetItemCount.toLocaleString()} resources?`, |
Contributor
There was a problem hiding this comment.
This will end up being weird if only 1 item is selected
Suggested change
| "promote-removals": (targetItemCount: number) => | |
| `Are you sure you want to remove these ${targetItemCount.toLocaleString()} resources?`, | |
| "promote-removals": (targetItemCount: number) => | |
| `Are you sure you want to remove ${targetItemCount.toLocaleString()} ${pluralize(targetItemCount, "resource", "resources")}?`, |
Contributor
Author
There was a problem hiding this comment.
We don't use that message for single items but I can add that since it isn't obvious/if someone decides to change that behavior.
Yes, that is currently expected but Adam is working to change that.
speaker-ender
force-pushed
the
feat/support-removals--ENG-1595
branch
from
51ccb98 to
1713c8d
Compare
speaker-ender
force-pushed
the
feat/support-removals--ENG-1595
branch
from
1713c8d to
fe9f1a8
Compare
chore: add remove action to dropdown fix: linting and formatting fix: adding disabled message wip: conditional action types feat: conditional actions chore: adding mute action to removals chore: update changelog fix: typo
speaker-ender
force-pushed
the
feat/support-removals--ENG-1595
branch
from
43ee6c1 to
a494e87
Compare
jjdaurora
pushed a commit
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket ENG-1595
Description Of Changes
removefields using the dropdown.Code Changes
Steps to Confirm
Helios V2beta flag is enabled in the settingsRestorebuttonRestorebuttonRemovedstatusMuteandRemovebutton on the list item as well as in the details trayRemovebutton handles the confirm-removal actionPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works