-
Notifications
You must be signed in to change notification settings - Fork 84
refactor: deselect on action [ENG-1789] #6942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
eb452a4 to
9522172
Compare
Greptile OverviewGreptile SummaryThis PR prevents stale state issues by clearing field selections after performing actions in the action center. The change makes action handlers async and calls
This addresses the issue where users could have stale selections after performing actions, potentially allowing invalid subsequent actions. Confidence Score: 5/5
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, no comments
jpople
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, confirmed working as expected.
fix: linting and formatting chore: update changelog
9522172 to
e7dfe5f
Compare
Ticket ENG-1789
Description Of Changes
Selected fields are de-selected after performing an action to prevent issues with async states.
Previously, if you selected multiple items and then performed an action, you would still have the same selection but with potentially stale states to base actionable logic.
Since we are not polling the state for each field, this can lead to invalid actions being available to a user.
Code Changes
Steps to Confirm
Helios V2beta flag is enabled in the settingsPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works