Skip to content

Conversation

@gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Nov 10, 2025

Description Of Changes

This PR introduces a set of rules and command definitions for the AI assistant. By committing these to the repository, we can ensure that AI-generated code and contributions align with our project's standards, conventions, and best practices. This includes frontend-specific guidelines, general rules, and a command for generating PR summaries.

Code Changes

  • Added .cursor/rules/general.mdc with general AI rules.
  • Added clients/.cursor/rules/frontend.mdc with frontend-specific AI rules.
  • Added .cursor/commands/pr-summary.md to define the PR summary command.
  • Updated .gitignore to track .cursor/rules and .cursor/commands directories.

Steps to Confirm

  1. Review the new rule and command files in the .cursor directory.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link

vercel bot commented Nov 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Nov 11, 2025 4:32pm
fides-privacy-center Ignored Ignored Nov 11, 2025 4:32pm

@gilluminate gilluminate marked this pull request as ready for review November 10, 2025 20:19
@gilluminate gilluminate requested a review from a team as a code owner November 10, 2025 20:19
@greptile-apps

This comment was marked as outdated.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

@gilluminate
Copy link
Contributor Author

@greptile

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@erosselli erosselli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a minor suggestion -- though the FE team might have other thoughts! 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is specifically for frontend, I think we should re-name it to frontend-pr-review.md :) that way we can also add a backend one in the future

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great suggestion. Updated.

Comment on lines -262 to -265

.cursor/rules
.cursor/implementation-plans
.cursor/commands
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice DX improvement 💯. All the rules and FE best practices look good to me ✅

@gilluminate gilluminate added this pull request to the merge queue Nov 11, 2025
Merged via the queue into main with commit 256b7a7 Nov 11, 2025
43 checks passed
@gilluminate gilluminate deleted the gill/fe-ai-rules branch November 11, 2025 17:16
jjdaurora pushed a commit that referenced this pull request Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants