-
Notifications
You must be signed in to change notification settings - Fork 84
fix: bulk select mode #6958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bulk select mode #6958
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
@speaker-ender tested in the preview link, it now stays in select all mode but the deselected items are not taken into account. https://www.loom.com/share/c97ac01e7d8d46628d30ee264a755a3a |
@lucanovera can you confirm if the values are sent in the request? |
8cc0254 to
0aaa3bc
Compare
You're right, it looks like the parms are correct so this would be a BE issue: |
Greptile OverviewGreptile SummaryFixed a bug where bulk actions were incorrectly triggered based on a derived boolean state ( Key changes:
Confidence Score: 5/5
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, no comments
gilluminate
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing the same BE bug Lucano is, but the code looks solid and the Post body does look correct.
chore: should have been in prev
87873a1 to
198276b
Compare

Ticket []
Description Of Changes
Fixing bug where incorrect action was taken because of incorrect variable usage.
Code Changes
listSelelectModeto determine if bulk actions should be used instead of theisBulkSelectvariable which was intended for the checkbox propsSteps to Confirm
Select Allcheckbox to enter theexclusiveselection modePre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works