-
Notifications
You must be signed in to change notification settings - Fork 84
freeze test times #6981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
freeze test times #6981
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6981 +/- ##
=======================================
Coverage 87.33% 87.33%
=======================================
Files 525 525
Lines 34458 34458
Branches 3967 3967
=======================================
Hits 30093 30093
Misses 3501 3501
Partials 864 864 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Greptile Summary
Confidence Score: 4/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 2 comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
| ), | ||
| ], | ||
| ) | ||
| @freeze_time("2025-11-17 12:00:00") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: using a date in 2025 could be confusing - prefer a clearly historical date like "2020-01-15 12:00:00" to make it obvious this is test fixture data
| ), | ||
| ], | ||
| ) | ||
| @freeze_time("2025-11-17 12:00:00") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: using a date in 2025 could be confusing - prefer a clearly historical date like "2020-01-15 12:00:00" to make it obvious this is test fixture data
Description Of Changes
Fixes a timing issue for some privacy request tests that occurred if they ran right on the border of midnight (00:00) UTC, e.g. in this CI run here.
Code Changes
freezegunto freeze time on these tests and avoid potential timing issuesSteps to Confirm
NOTE: CI did fail on attempt #1 on this PR with the following test error:
this isn't directly related to the changes on this PR, but it's also close enough that i can't be 100% sure i'm not introducing a test regression here. that being said, @erosselli and i couldn't find any reason why the changes here would have caused that failure, so we suspect it's always been a flaky test and i just happened to hit the failure case on the CI run here...
CI did not fail on this test on attempt #2, and also didn't fail on the 3.9 python run, so our inclination is to just consider this a coincidence and go ahead and merge this improvement 👍
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works