ENG-1968 Google Consent Mode v2 #6982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed gtag-consent to gcm for better naming consistency - Updated default mapping to include data_sales_and_sharing and marketing consent keys (per JJ's PR feedback) - Both map to [ad_storage, ad_personalization, ad_user_data] for comprehensive Google ad consent - Made integration resilient to missing consent keys - only processes keys present in both mapping and Fides consent - Added comprehensive JSDoc documentation with usage examples - Integrated into Fides global API (Fides.gcm()) Addresses feedback from PR #6950
- Replaced all console.log, console.warn, console.error calls with fidesDebugger - Removed debug option from GcmOptions interface - Removed debug parameter from buildGoogleConsent and pushConsentToGtag functions - Updated JSDoc to remove references to debug flag - Matches the pattern used in aep integration for consistent debugging approach - fidesDebugger handles debug flag internally via Fides.options.debug
Test coverage includes: - Default purpose mapping with all standard consent keys (analytics, advertising, functional, data_sales_and_sharing, marketing) - Custom purpose mapping with various configurations - Consent granted vs denied states - Graceful degradation when consent keys are missing from Fides - Multiple consent keys mapping to same Google type (last write wins) - Single consent key mapping to multiple Google types - Edge cases: empty consent, undefined values, falsy values, truthy non-boolean values - gtag not loaded scenario (graceful failure) - Event subscription (FidesReady, FidesUpdated) - Immediate consent push when Fides already initialized - consent() API (returns null as gtag doesn't provide read API) - All seven Google consent types supported Follows same test patterns as aep.test.ts but excludes debug logging tests per user request
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
The test was failing because event listeners from previous tests accumulate. Instead of checking that gtag was never called (which fails due to accumulated listeners), we verify that gtag was never called with an empty consent object. This tests the actual behavior: when mapping has empty arrays, the integration correctly skips calling gtag (returns early when Object.keys(googleConsent).length === 0). All 23 tests now pass.
thabofletcher
force-pushed
the
ENG-1968-google-consent-mode
branch
from
567689d to
65d9e69
Compare
Regenerated TypeDoc documentation to include Fides.gcm() API
Closed
gilluminate
reviewed
Nov 17, 2025
Co-authored-by: Jason Gill <jason.gill@ethyca.com>
Instead of gtag?: (...args: any[]) => void, define: - GtagConsentCommand: specific signature for consent commands we use - GtagFunction: intersection type for consent + general gtag calls Provides proper type safety while allowing gtag to be called with other commands outside our integration (e.g., event tracking, config, etc.)
thabofletcher
requested review from
speaker-ender
and removed request for
a team and
speaker-ender
Contributor
Greptile Summary
Confidence Score: 4/5
Important Files Changed
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
7 files reviewed, 1 comment
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
…yca/fides into ENG-1968-google-consent-mode
gilluminate
approved these changes
Nov 18, 2025
Contributor
gilluminate
left a comment
gilluminate
left a comment
There was a problem hiding this comment.
Looking good to me! Tested on granger.com and was able to see the dataLayer working as expected
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
jjdaurora
pushed a commit
that referenced
this pull request
Dec 5, 2025
Co-authored-by: Jason Gill <jason.gill@ethyca.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket [ENg-1968]
Description Of Changes
Introduces the gcm() integrataion to support Google Consent Mode v2 in situations where Google Tag Manager is not in use (our current gtm() integration support GCMv2 through the use of a GTM template)
Code Changes
Steps to Confirm
window.dataLayerto see the current gtag eventsPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works