Skip to content

Conversation

@tvandort
Copy link
Contributor

@tvandort tvandort commented Nov 17, 2025

Ticket ENG-1992

Description Of Changes

Open api docs say pre-execution when they mean pre-approval.

Code Changes

  • Rename some functions.

Steps to Confirm

  1. Check that pre-approval web hooks say pre-approval and not pre-execution on swagger docs.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@tvandort tvandort requested a review from a team as a code owner November 17, 2025 19:27
@tvandort tvandort requested review from galvana and removed request for a team November 17, 2025 19:27
@vercel
Copy link

vercel bot commented Nov 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Nov 17, 2025 7:55pm
fides-privacy-center Ignored Ignored Nov 17, 2025 7:55pm

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 17, 2025

Greptile Summary

  • Renamed three endpoint functions from *_pre_execution_* to *_pre_approval_* for consistent terminology
  • Updated log messages and inline comments to use "Pre-Approval" instead of "Pre-Execution"

Confidence Score: 5/5

  • This PR is safe to merge with no risk - it only contains documentation and naming fixes.
  • The changes are purely cosmetic, renaming functions and updating documentation strings for consistency. No logic changes, no behavioral changes, and no dependencies affected. All references have been consistently updated.
  • No files require special attention

Important Files Changed

Filename Overview
src/fides/api/api/v1/endpoints/pre_approval_webhook_endpoints.py Renamed function names and updated documentation strings from "pre-execution" to "pre-approval" for terminology consistency.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

Copy link
Contributor

@erosselli erosselli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was not at all confusing.. 😆

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.33%. Comparing base (cb7c97d) to head (b29c022).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6985   +/-   ##
=======================================
  Coverage   87.33%   87.33%           
=======================================
  Files         525      525           
  Lines       34458    34458           
  Branches     3967     3967           
=======================================
  Hits        30093    30093           
  Misses       3501     3501           
  Partials      864      864           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvandort tvandort added this pull request to the merge queue Nov 17, 2025
Merged via the queue into main with commit 69e950e Nov 17, 2025
69 checks passed
@tvandort tvandort deleted the ENG-1992 branch November 17, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants