-
Notifications
You must be signed in to change notification settings - Fork 84
Fix SSO login button not appearing after session timeout without manual refresh #6988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SSO login button not appearing after session timeout without manual refresh #6988
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Greptile Summary
Confidence Score: 5/5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format
|
Have you tested this with just the |
@gilluminate you are right those refetches were not necessary. I have tested with just |
Ticket ENG-1466
Description Of Changes
Fixed an issue where the SSO login button was not visible after an idle timeout. Previously, when users returned to the login page after their session expired, the SSO providers query would not refetch, causing the SSO button to be missing until a manual page refresh.
This change adds refetch options to the authentication methods and SSO providers queries on the login page. The queries will now automatically refetch when:
This ensures that users returning to the login page after a timeout will see the SSO button immediately without needing to manually refresh the page.
Code Changes
useGetAuthenticationMethodsQueryhook inclients/admin-ui/src/pages/login.tsxuseGetAllOpenIDProvidersSimpleQueryhook inclients/admin-ui/src/pages/login.tsxrefetchOnMountOrArgChange: trueSteps to Confirm
/login)Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works