Skip to content

Conversation

@speaker-ender
Copy link
Contributor

@speaker-ender speaker-ender commented Nov 26, 2025

Ticket [ENG-1999, ENG-2000]

Description Of Changes

Restores all of the previous confidence score visuals along with an update to the number of confidence levels.

Code Changes

  • Updated API types to support new confidence levels
  • Refactored the ClassifierProgress component into a generic SeverityGauge for reuse
  • Mapped ConfidenceBucket values to Severity to utilize the new component
  • Updated the filters to include the classifier progress

Steps to Confirm

Classifier steps

  1. Add datastore_monitor_action_center_enabled = true to the [detection_discovery] section of the .fides/fides.toml file in fidesplus
  2. Enable the Helios v2 feature flag by going to /settings/about and toggling the option
  3. Add a new datastore monitor (can follow the steps in src/fidesplus/api/service/discovery/configurable-test-datastore-monitor.md) with the simulate_classification: true in the datasource_params of a custom configuration.
  4. Visit the Action Center Page
  5. Click on a monitor to navigate to a datastore monitor (eg http://localhost:3000/data-discovery/action-center/datastore/Default_Test_Datastore_Monitor)

Confidence score steps

  1. Click the classify button on any field
  2. Confirm that the confidence level is displayed in the list view once an item has successfully been classified
  3. Open the drawer for a classified resource and confirm that the confidence level is correctly displayed
  4. Test the functionality of the Confidence filter in the filters dropdown

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link

vercel bot commented Nov 26, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
fides-plus-nightly Ready Ready Preview Comment Dec 2, 2025 3:41pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
fides-privacy-center Ignored Ignored Dec 2, 2025 3:41pm

@speaker-ender speaker-ender force-pushed the feat/restore-confidence-score branch 2 times, most recently from b96eaaf to 6ba27a6 Compare November 26, 2025 19:05
@speaker-ender speaker-ender force-pushed the feat/restore-confidence-score branch from 6ba27a6 to 57dcc3a Compare December 1, 2025 14:17
@speaker-ender speaker-ender marked this pull request as ready for review December 1, 2025 14:29
@speaker-ender speaker-ender requested a review from a team as a code owner December 1, 2025 14:29
@speaker-ender speaker-ender requested review from lucanovera and removed request for a team December 1, 2025 14:29
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 1, 2025

Greptile Overview

Greptile Summary

This PR restores confidence score visuals by refactoring the ClassifierProgress component into a more generic SeverityGauge component that supports three confidence levels (low, medium, high). The changes include:

  • API type updates: Replaced ConfidenceScoreRange with ConfidenceBucket enum (adding MEDIUM level), updated ClassificationWithConfidence to include rationale and confidence_rating fields
  • Component refactoring: Created reusable SeverityGauge component with 3-step progress visualization and severity-based color coding
  • Filter integration: Added confidence bucket filtering to the Monitor Fields page with proper URL state management
  • Type consistency: Updated all resource models (Database, Schema, Table, Field) to use ClassificationWithConfidence instead of Classification

Critical Issue Found: The types.d.ts file still imports and uses the deleted ConfidenceScoreRange type, which will cause TypeScript compilation to fail. This must be fixed before merging.

Confidence Score: 2/5

  • PR has a TypeScript compilation error that will prevent the build from succeeding.
  • The PR contains a critical type error where ConfidenceScoreRange is still imported and used in types.d.ts but the type file was deleted. This will cause TypeScript compilation to fail. Once this issue is fixed, the PR would be safe to merge as the remaining changes are well-structured refactoring work.
  • clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/types.d.ts - references deleted ConfidenceScoreRange type

Important Files Changed

File Analysis

Filename Score Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/types.d.ts 1/5 Critical: References deleted ConfidenceScoreRange type instead of ConfidenceBucket, will cause TypeScript compilation failure.
clients/admin-ui/src/features/common/progress/SeverityGauge/index.tsx 5/5 New generic SeverityGauge component refactored from ClassifierProgress, supports three severity levels (low/medium/high) with customizable labels.
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/utils.ts 5/5 Added ConfidenceBucket to Severity mapping functions (mapConfidenceBucketToSeverity, getMaxSeverity) for use with SeverityGauge.
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/MonitorFieldFilters.tsx 5/5 Added confidence bucket filtering support with local state management, tree data integration, and proper sync with applied filters.
clients/admin-ui/src/types/api/models/ConfidenceBucket.ts 5/5 New enum replacing ConfidenceScoreRange with four values: LOW, HIGH, MEDIUM, MANUAL.
clients/admin-ui/src/types/api/models/ClassificationWithConfidence.ts 5/5 Updated to use ConfidenceBucket instead of ConfidenceScoreRange, added rationale and confidence_rating fields.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (1)

  1. clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/types.d.ts, line 4 (link)

    syntax: ConfidenceScoreRange was deleted from the codebase in this PR (file ConfidenceScoreRange.ts removed), but is still being imported here. This will cause a TypeScript compilation error. It should be replaced with ConfidenceBucket to match the renamed type.

23 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

chore: restoring confidence sore filters

chore: api updates

chore: more api updates

fix: updates after api updates

chore: more fixes

chore: wip

chore: api update

chore: more wip

chore: api update

fix: query params and formatting

fix: score percentages

fix: list items

fix: color mapping

fix: remove unused fn and disabled lint

refactor: specialized classifier component to generic gauge

chore: updating changelog

fix: outdated type usage

refactor: review feedback
Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@speaker-ender speaker-ender added this pull request to the merge queue Dec 2, 2025
Merged via the queue into main with commit 1c4d3fa Dec 2, 2025
46 of 47 checks passed
@speaker-ender speaker-ender deleted the feat/restore-confidence-score branch December 2, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants