-
Notifications
You must be signed in to change notification settings - Fork 84
feat: restore confidence score [ENG-1999, ENG-2000] #7040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
clients/admin-ui/src/features/classifier/ClassifierProgress.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/classifier/ClassifierProgress.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/classifier/ClassifierProgress.tsx
Outdated
Show resolved
Hide resolved
b96eaaf to
6ba27a6
Compare
6ba27a6 to
57dcc3a
Compare
Greptile OverviewGreptile SummaryThis PR restores confidence score visuals by refactoring the
Critical Issue Found: The Confidence Score: 2/5
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/types.d.ts, line 4 (link)syntax:
ConfidenceScoreRangewas deleted from the codebase in this PR (fileConfidenceScoreRange.tsremoved), but is still being imported here. This will cause a TypeScript compilation error. It should be replaced withConfidenceBucketto match the renamed type.
23 files reviewed, 2 comments
clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/types.d.ts
Outdated
Show resolved
Hide resolved
0bc9082 to
8a79aa5
Compare
...in-ui/src/features/data-discovery-and-detection/action-center/fields/MonitorFieldFilters.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/common/progress/SeverityGauge/constants.ts
Outdated
Show resolved
Hide resolved
...in-ui/src/features/data-discovery-and-detection/action-center/fields/MonitorFieldFilters.tsx
Show resolved
Hide resolved
clients/admin-ui/src/features/common/progress/SeverityGauge/index.tsx
Outdated
Show resolved
Hide resolved
...n-ui/src/features/data-discovery-and-detection/action-center/fields/MonitorFieldListItem.tsx
Outdated
Show resolved
Hide resolved
09ecb60 to
651b7ff
Compare
chore: restoring confidence sore filters chore: api updates chore: more api updates fix: updates after api updates chore: more fixes chore: wip chore: api update chore: more wip chore: api update fix: query params and formatting fix: score percentages fix: list items fix: color mapping fix: remove unused fn and disabled lint refactor: specialized classifier component to generic gauge chore: updating changelog fix: outdated type usage refactor: review feedback
651b7ff to
549b217
Compare
gilluminate
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Ticket [ENG-1999, ENG-2000]
Description Of Changes
Restores all of the previous confidence score visuals along with an update to the number of confidence levels.
Code Changes
ClassifierProgresscomponent into a genericSeverityGaugefor reuseConfidenceBucketvalues toSeverityto utilize the new componentSteps to Confirm
Classifier steps
datastore_monitor_action_center_enabled = trueto the[detection_discovery]section of the.fides/fides.tomlfile in fidesplus/settings/aboutand toggling the optionsimulate_classification: truein thedatasource_paramsof a custom configuration.Confidence score steps
Confidencefilter in the filters dropdownPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works