-
Notifications
You must be signed in to change notification settings - Fork 84
Sticky column headers for tables #7060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…b.com/ethyca/fides into jpople/eng-1489/sticky-column-headers
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Greptile OverviewGreptile SummaryThis PR implements sticky column headers and action bars for multiple tables across the admin UI, improving usability when scrolling through long tables. Key changes:
Confidence Score: 5/5
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
18 files reviewed, no comments
speaker-ender
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with known issue of horizontal scroll bar misalignment.
Follow up will refactor to use a max-height on the table with overflow to avoid stacked sticky elements.
Ticket ENG-1489
Description Of Changes
See description on #6813; some layouts have been tweaked from that PR and static column widths were added to fix the issues that came up in ENG-1748.
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works