Skip to content
This repository was archived by the owner on Nov 30, 2022. It is now read-only.
This repository was archived by the owner on Nov 30, 2022. It is now read-only.

Too many health check db connections  #1102

@pattisdr

Description

@pattisdr

Bug Description

The health check endpoint is creating new engines which are probably creating their own connection pools each time it is called. We should be sharing an engine https://github.com/ethyca/fidesops/blob/main/src/fidesops/ops/api/v1/endpoints/health_endpoints.py#L37

This opens up too many connections against the fidesops database very quickly.

h/t @RobertKeyser and @sanders41 for finding this.

Steps to Reproduce

Bring up the fidesops server and monitor your connections against the fidesops application database.

Expected behavior

A description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Environment

  • Version:
  • OS:
  • Python Version:
  • Docker Version:

Additional context

Add any other context about the problem here.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions