Skip to content
This repository was archived by the owner on Nov 30, 2022. It is now read-only.
This repository was archived by the owner on Nov 30, 2022. It is now read-only.

Backend: Indicate Webhook Fields have Changed #1389

@pattisdr

Description

@pattisdr

Is your feature request related to a specific problem?

If webhook fields are edited, they may differ from data already saved for a requires_input PrivacyRequest and require re-review before the privacy request is queued again for processing.

Currently the backend throws a 429 when retrieving mismatched data, but we need to make this more actionable.

Describe the solution you'd like

  • When retrieving manual input data for a privacy request (view_uploaded_manual_webhook_data), if the fields saved to the privacy request differ from the fields on the webhook (Either a field has been deleted or a field has been removed), we need to surface in the API that this webhook needs to be re-reviewed (checked=False). Currently we just show checked=False if there's no data in the cache. Perhaps we change the variable name here.
  • Noting, don't update the data in the cache (to preserve that this webhook still needs to be re-reviewed, even if the page is refreshed). This data will need to be overwritten.
  • However, in the API return just the data that overlaps between existing data and the current webhook fields.
  • Leave other endpoints the same: resume_privacy_request_from_requires_input will still 429 if there's a mismatch to protect this from a backend perspective.

Describe alternatives you've considered, if any

A description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions