Skip to content
This repository was archived by the owner on Nov 30, 2022. It is now read-only.

Conversation

@sadaqatullah
Copy link
Contributor

@sadaqatullah sadaqatullah commented Aug 12, 2022

Purpose

Pagination doesn't retain headers of first request. This implements bugfix for that.

Changes

  • Mapping original request headers in requests generated from pagination.

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Good unit test/integration test coverage

Ticket

Fixes #1066

@sadaqatullah sadaqatullah requested a review from galvana August 12, 2022 15:07
@galvana galvana changed the title Added Headers in SaaSRequestParams [WIP] Preserving headers headers in SaaSRequestParams during pagination Aug 12, 2022
@galvana galvana changed the title Preserving headers headers in SaaSRequestParams during pagination Preserving headers in SaaSRequestParams during pagination Aug 12, 2022
Copy link
Collaborator

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for identifying and fixing this so quickly, this all looks good to go!

@galvana galvana merged commit 7e77d0c into main Aug 12, 2022
@galvana galvana deleted the bug-fix/headers-missing-in-pagination branch August 12, 2022 16:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Headers missing in Paginated Requests

3 participants