This repository was archived by the owner on Nov 30, 2022. It is now read-only.
Adds AuditLog and ExecutionLogs to seed_test_data command
#1097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpreston
changed the title
seed_test_data commandAuditLog and ExecutionLogs to seed_test_data command
pattisdr
reviewed
Aug 17, 2022
scripts/create_test_data.py
Outdated
| "message": f"Execution log for request id {pr.id} status {status} and action_type {action_type}", | ||
| }, | ||
| ) | ||
| # run_privacy_request.apply(args=[pr.id]) # Run the request synchronously |
pattisdr
reviewed
Aug 17, 2022
scripts/create_test_data.py
Outdated
| data={ | ||
| "dataset_name": "dummy_dataset", | ||
| "collection_name": "dummy_collection", | ||
| "fields_affected": ["dummy_field_1", "dummy_field_2"], |
Contributor
There was a problem hiding this comment.
This isn't the correct format for fields_affected - it looks more like:
[{
"path": "dataset_name:collection_name:field_name",
"field_name": "field_name",
"data_categories": ["data_category_1", "data_category_2"]
}]
pattisdr
reviewed
Aug 17, 2022
Comment on lines
204
to
206
| AuditLogAction.approved, | ||
| AuditLogAction.denied, | ||
| AuditLogAction.finished, |
Contributor
There was a problem hiding this comment.
i know this is dummy data, but maybe switching the order of approved and denied might be useful, so in a demo it doesn't look like it was denied and then it finished
pattisdr
reviewed
Aug 17, 2022
Contributor
pattisdr
left a comment
pattisdr
left a comment
There was a problem hiding this comment.
good improvement to our test data!
pattisdr
reviewed
Aug 17, 2022
| "path": "dummy_dataset:dummy_collection:dummy_field_1", | ||
| "field_name": "dummy_field", | ||
| "data_categories": [ | ||
| "data_category_1", |
Contributor
There was a problem hiding this comment.
I think this is a fine for now, but at some point we may be using this data and have validation where Pydantic expects them to be proper data categories.
pattisdr
approved these changes
Aug 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds test
AuditLogandExecutionLogdata to theseed_test_datacommand.Changes
AuditLogandExecutionLogs for createdPrivacyRequestobjects of every permutation of action and status.Checklist
CHANGELOG.mdfileCHANGELOG.mdfile is being appended toUnreleasedsection in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external services