Skip to content
This repository was archived by the owner on Nov 30, 2022. It is now read-only.

update Subject Request detail page #1164

Merged
TheAndrewJackson merged 7 commits into from
Aug 29, 2022
Merged

update Subject Request detail page #1164

TheAndrewJackson merged 7 commits into from
Aug 29, 2022

Conversation

@conceptualshark
Copy link
Contributor

@conceptualshark conceptualshark commented Aug 26, 2022 •
edited
Loading

Purpose

The Subject Request UI page was missing some notes on the enhanced details/log and error reprocessing.

Changes

  • added a note that you can reprocess errored requests from the details page
  • added info on how to access the event log and full history

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #

@conceptualshark conceptualshark marked this pull request as ready for review August 26, 2022 14:17
TheAndrewJackson
TheAndrewJackson suggested changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It's ready to merge once the analytics id is removed.

fidesops.toml Outdated

[root_user]
analytics_opt_out = false
analytics_id = "9a9b4b632ca76d5cb87b4faf48519125"
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson Aug 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
analytics_id = "9a9b4b632ca76d5cb87b4faf48519125"

@TheAndrewJackson TheAndrewJackson merged commit 6f0c3d2 into main Aug 29, 2022
@TheAndrewJackson TheAndrewJackson deleted the cg-ui-doc-updates branch August 29, 2022 20:34
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
@conceptualshark
update Subject Request detail page (#1164)
30d68ff 
* [#495] clarify additions to subject request event log

* [#863] note retry capabilities in subject requests

* changelog

* fidesops.toml

* changelog

Co-authored-by: Cole Garbo <colegarbo@Ethycas-MacBook-Pro.local>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@TheAndrewJackson TheAndrewJackson TheAndrewJackson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TheAndrewJackson TheAndrewJackson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@conceptualshark @TheAndrewJackson