This repository was archived by the owner on Nov 30, 2022. It is now read-only.
Human Readable Names for Connection Types [#1096] #1297
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Update our ConnectionType endpoint to surface an additional human readable name of the connector (database/saas/manual)
Changes
My goal was to keep these mappings out of the database.
human_readableattribute to the registry.Updated endpoint
GET /connection_type{ "items": [ { "identifier": "bigquery", "type": "database", "human_readable": "BigQuery" }, { "identifier": "mariadb", "type": "database", "human_readable": "MariaDB" }, { "identifier": "mongodb", "type": "database", "human_readable": "MongoDB" }, { "identifier": "mssql", "type": "database", "human_readable": "Microsoft SQL Server" }, { "identifier": "mysql", "type": "database", "human_readable": "MySQL" }, { "identifier": "postgres", "type": "database", "human_readable": "PostgreSQL" }, { "identifier": "redshift", "type": "database", "human_readable": "Amazon Redshift" }, { "identifier": "snowflake", "type": "database", "human_readable": "Snowflake" }, { "identifier": "adobe_campaign", "type": "saas", "human_readable": "Adobe Campaign" }, { "identifier": "auth0", "type": "saas", "human_readable": "Auth0" }, { "identifier": "datadog", "type": "saas", "human_readable": "Datadog" }, { "identifier": "hubspot", "type": "saas", "human_readable": "HubSpot" }, { "identifier": "mailchimp", "type": "saas", "human_readable": "Mailchimp" }, { "identifier": "outreach", "type": "saas", "human_readable": "Outreach" }, { "identifier": "salesforce", "type": "saas", "human_readable": "Salesforce" }, { "identifier": "segment", "type": "saas", "human_readable": "Segment" }, { "identifier": "sendgrid", "type": "saas", "human_readable": "SendGrid" }, { "identifier": "sentry", "type": "saas", "human_readable": "Sentry" }, { "identifier": "shopify", "type": "saas", "human_readable": "Shopify" }, { "identifier": "stripe", "type": "saas", "human_readable": "Stripe" }, { "identifier": "zendesk", "type": "saas", "human_readable": "Zendesk" }, { "identifier": "manual_webhook", "type": "manual", "human_readable": "Manual Webhook" } ], "total": 23, "page": 1, "size": 50 }Checklist
CHANGELOG.mdfileCHANGELOG.mdfile is being appended toUnreleasedsection in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #1096