This repository was archived by the owner on Nov 30, 2022. It is now read-only.
Add generic request sorting button #1320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAndrewJackson
changed the title
| const handleButtonClick = useCallback(() => { | ||
| setWasButtonJustClicked(true); | ||
| dispatch(setSortField(sortField)); | ||
| if (buttonState === ButtonState.UNSELECTED) { |
Contributor
There was a problem hiding this comment.
A switch statement here will make this snippet easier to read.
clients/ops/admin-ui/src/features/privacy-requests/SortRequestButton.tsx
Show resolved
Hide resolved
clients/ops/admin-ui/src/features/privacy-requests/SortRequestButton.tsx
Outdated
Show resolved
Hide resolved
chriscalhoun1974
suggested changes
Sep 14, 2022
Contributor
chriscalhoun1974
left a comment
chriscalhoun1974
left a comment
There was a problem hiding this comment.
Left some minor comments. Great work!
chriscalhoun1974
approved these changes
Sep 15, 2022
sanders41
pushed a commit
that referenced
this pull request
Sep 22, 2022
* Add generic request sort button * Update changelog * Implement PR feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add sorting button that can be used for other subject requests fields in the future.
Changes
sort_fieldandsort_directiontoPrivacyRequestParamsSortingButton.mov
Checklist
CHANGELOG.mdfileCHANGELOG.mdfile is being appended toUnreleasedsection in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #1152